src/api.cc - Issue 6731054: Fix a number of GC-unsafe evaluation order dependent places....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 6731054: Fix a number of GC-unsafe evaluation order dependent places.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/api.cc

===================================================================

--- src/api.cc (revision 7417)

+++ src/api.cc (working copy)

@@ -4246,7 +4246,9 @@

ENTER_V8(isolate);

int real_length = length > 0 ? length : 0;

i::Handle<i::JSArray> obj = isolate->factory()->NewJSArray(real_length);

- obj->set_length(*isolate->factory()->NewNumberFromInt(real_length));

+ i::Handle<i::Object> length_obj =

+ isolate->factory()->NewNumberFromInt(real_length);

+ obj->set_length(*length_obj);

return Utils::ToLocal(obj);

}

« no previous file with comments | « no previous file | src/bootstrapper.cc » ('j') | no next file with comments »