Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 6731054: Fix a number of GC-unsafe evaluation order dependent places.... (Closed)

Created:
9 years, 9 months ago by Vyacheslav Egorov (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix a number of GC-unsafe evaluation order dependent places. Also change places which are triggering false positive alert in our static analysis tool. Committed: http://code.google.com/p/v8/source/detail?r=7432

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -28 lines) Patch
M src/api.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/bootstrapper.cc View 4 chunks +25 lines, -17 lines 0 comments Download
M src/liveedit.cc View 3 chunks +13 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vyacheslav Egorov (Chromium)
9 years, 9 months ago (2011-03-29 17:58:42 UTC) #1
Mads Ager (chromium)
9 years, 9 months ago (2011-03-29 18:14:32 UTC) #2
LGTM! Thanks Slava!

Powered by Google App Engine
This is Rietveld 408576698