Fix up some reference counting when WebPluginImpl::scriptableObject is called.

Fix up some reference counting when WebPluginImpl::scriptableObject is called.

BUG= http://code.google.com/p/chromium-os/issues/detail?id=13605
TEST=Manual testing before/after change.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79712

[piman, 2011-03-29 16:19:46]

There's also one more thing to fix to make sure refcount is correct (not your
fault): PluginObject::Create should release the NPObject after putting it into
the ObjectVar.

http://codereview.chromium.org/6731051/diff/1004/webkit/plugins/ppapi/ppapi_w...
File webkit/plugins/ppapi/ppapi_webplugin_impl.cc (right):

http://codereview.chromium.org/6731051/diff/1004/webkit/plugins/ppapi/ppapi_w...
webkit/plugins/ppapi/ppapi_webplugin_impl.cc:97:
instance_->message_channel().set_passthrough_object(object->np_object());
The message channel should also retain the passthrough object when setting it,
and releasing it when done.

http://codereview.chromium.org/6731051/diff/1004/webkit/plugins/ppapi/ppapi_w...
webkit/plugins/ppapi/ppapi_webplugin_impl.cc:99: NPObject*
message_channel_np_object;
= instance_->message_channel().np_object() ?

[dmichael(do not use this one), 2011-03-29 16:56:10]

Sorry for the hasty first CL. I think this is a bit better.

http://codereview.chromium.org/6731051/diff/1004/webkit/plugins/ppapi/ppapi_w...
File webkit/plugins/ppapi/ppapi_webplugin_impl.cc (right):

http://codereview.chromium.org/6731051/diff/1004/webkit/plugins/ppapi/ppapi_w...
webkit/plugins/ppapi/ppapi_webplugin_impl.cc:97:
instance_->message_channel().set_passthrough_object(object->np_object());
On 2011/03/29 16:19:47, piman wrote:
> The message channel should also retain the passthrough object when setting it,
> and releasing it when done.
That's what I thought...  I was trying to slap together a CL to address what I
thought was your initial diagnosis, and slapped it together too quickly.

http://codereview.chromium.org/6731051/diff/1004/webkit/plugins/ppapi/ppapi_w...
webkit/plugins/ppapi/ppapi_webplugin_impl.cc:99: NPObject*
message_channel_np_object;
On 2011/03/29 16:19:47, piman wrote:
> = instance_->message_channel().np_object() ?
Yeah, I hit send too hastily.  Sorry.

[piman, 2011-03-29 17:36:10]

one last thing, then it's good to go

http://codereview.chromium.org/6731051/diff/4005/webkit/plugins/ppapi/message...
File webkit/plugins/ppapi/message_channel.cc (right):

http://codereview.chromium.org/6731051/diff/4005/webkit/plugins/ppapi/message...
webkit/plugins/ppapi/message_channel.cc:396:
WebBindings::retainObject(passthrough_object_);
Do you mind retaining before releasing ? Just in case someone ends up doing
SetPassthroughObject(passthrough_object()).

[dmichael(do not use this one), 2011-03-29 18:03:21]

Hopefully this does it.  Thanks for finding the issue(s).

http://codereview.chromium.org/6731051/diff/4005/webkit/plugins/ppapi/message...
File webkit/plugins/ppapi/message_channel.cc (right):

http://codereview.chromium.org/6731051/diff/4005/webkit/plugins/ppapi/message...
webkit/plugins/ppapi/message_channel.cc:396:
WebBindings::retainObject(passthrough_object_);
On 2011/03/29 17:36:10, piman wrote:
> Do you mind retaining before releasing ? Just in case someone ends up doing
> SetPassthroughObject(passthrough_object()).
Done.  (Although I might argue that anyone doing that deserves a crash :-p)

[piman, 2011-03-29 18:05:40]

LGTM, thanks !

[dmichael(do not use this one), 2011-03-29 20:19:00]

FYI:  I was able to manually reproduce the problem before the change, and was
unable to reproduce with the change, so it looks like this fixed the problem. 
Thanks again for the great diagnosis.

[piman, 2011-03-29 20:39:57]

On Tue, Mar 29, 2011 at 1:19 PM, <dmichael@google.com> wrote:

> FYI:  I was able to manually reproduce the problem before the change, and
> was
> unable to reproduce with the change, so it looks like this fixed the
> problem.
> Thanks again for the great diagnosis.

Great, thanks !


>
>
> http://codereview.chromium.org/6731051/
>