Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 6731046: Fix null-pointer dereference in the compiler when running without sse3 support. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1617 matching lines...) Expand 10 before | Expand all | Expand 10 after
1628 LOperand* value = UseRegister(instr->value()); 1628 LOperand* value = UseRegister(instr->value());
1629 LNumberUntagD* res = new LNumberUntagD(value); 1629 LNumberUntagD* res = new LNumberUntagD(value);
1630 return AssignEnvironment(DefineAsRegister(res)); 1630 return AssignEnvironment(DefineAsRegister(res));
1631 } else { 1631 } else {
1632 ASSERT(to.IsInteger32()); 1632 ASSERT(to.IsInteger32());
1633 LOperand* value = UseRegister(instr->value()); 1633 LOperand* value = UseRegister(instr->value());
1634 bool needs_check = !instr->value()->type().IsSmi(); 1634 bool needs_check = !instr->value()->type().IsSmi();
1635 if (needs_check) { 1635 if (needs_check) {
1636 CpuFeatures* cpu_features = Isolate::Current()->cpu_features(); 1636 CpuFeatures* cpu_features = Isolate::Current()->cpu_features();
1637 LOperand* xmm_temp = 1637 LOperand* xmm_temp =
1638 (instr->CanTruncateToInt32() && !cpu_features->IsSupported(SSE3)) 1638 (instr->CanTruncateToInt32() && cpu_features->IsSupported(SSE3))
1639 ? NULL 1639 ? NULL
1640 : FixedTemp(xmm1); 1640 : FixedTemp(xmm1);
1641 LTaggedToI* res = new LTaggedToI(value, xmm_temp); 1641 LTaggedToI* res = new LTaggedToI(value, xmm_temp);
1642 return AssignEnvironment(DefineSameAsFirst(res)); 1642 return AssignEnvironment(DefineSameAsFirst(res));
1643 } else { 1643 } else {
1644 return DefineSameAsFirst(new LSmiUntag(value, needs_check)); 1644 return DefineSameAsFirst(new LSmiUntag(value, needs_check));
1645 } 1645 }
1646 } 1646 }
1647 } else if (from.IsDouble()) { 1647 } else if (from.IsDouble()) {
1648 if (to.IsTagged()) { 1648 if (to.IsTagged()) {
(...skipping 492 matching lines...) Expand 10 before | Expand all | Expand 10 after
2141 LInstruction* LChunkBuilder::DoLeaveInlined(HLeaveInlined* instr) { 2141 LInstruction* LChunkBuilder::DoLeaveInlined(HLeaveInlined* instr) {
2142 HEnvironment* outer = current_block_->last_environment()->outer(); 2142 HEnvironment* outer = current_block_->last_environment()->outer();
2143 current_block_->UpdateEnvironment(outer); 2143 current_block_->UpdateEnvironment(outer);
2144 return NULL; 2144 return NULL;
2145 } 2145 }
2146 2146
2147 2147
2148 } } // namespace v8::internal 2148 } } // namespace v8::internal
2149 2149
2150 #endif // V8_TARGET_ARCH_IA32 2150 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698