Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: chrome/browser/autocomplete/autocomplete_popup_model.h

Issue 6731036: Enabled pressing TAB to cycle through the Omnibox results. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/autocomplete_popup_model.h
===================================================================
--- chrome/browser/autocomplete/autocomplete_popup_model.h (revision 94623)
+++ chrome/browser/autocomplete/autocomplete_popup_model.h (working copy)
@@ -53,6 +53,10 @@
return selected_line_;
}
+ bool keyword_selected() const {
+ return keyword_selected_;
+ }
+
// Call to change the selected line. This will update all state and repaint
// the necessary parts of the window, as well as updating the edit with the
// new temporary text. |line| will be clamped to the range of valid lines.
@@ -69,19 +73,6 @@
// will change the selected line back to the default match and redraw.
void ResetToDefaultMatch();
- // Gets the selected keyword or keyword hint for the given match. If the match
- // is already keyword, then the keyword will be returned directly. Otherwise,
- // it returns GetKeywordForText(match.fill_into_edit, keyword).
- bool GetKeywordForMatch(const AutocompleteMatch& match,
- string16* keyword) const;
-
- // Gets the selected keyword or keyword hint for the given text. Returns
- // true if |keyword| represents a keyword hint, or false if |keyword|
- // represents a selected keyword. (|keyword| will always be set [though
- // possibly to the empty string], and you cannot have both a selected keyword
- // and a keyword hint simultaneously.)
- bool GetKeywordForText(const string16& text, string16* keyword) const;
-
// Immediately updates and opens the popup if necessary, then moves the
// current selection down (|count| > 0) or up (|count| < 0), clamping to the
// first or last result if necessary. If |count| == 0, the selection will be
@@ -89,6 +80,11 @@
// AutocompleteEditModel.
void Move(int count);
+ // If the selected line has both a normal match and a keyword match, this can
+ // be used to choose which to select. It is an error to call this when the
+ // selected line does not have both matches (or there is no selection).
+ void SelectKeyword(bool selected);
sky 2011/08/01 16:02:15 Using selected as the name to a function call Sele
+
// Called when the user hits shift-delete. This should determine if the item
// can be removed from history, and if so, remove it and update the popup.
void TryDeletingCurrentItem();
@@ -126,6 +122,11 @@
// which should only be true when the popup is closed.
size_t selected_line_;
+ // If the selected line has both a normal match and a keyword match, this
+ // determines whether the normal match (if false) or the keyword match
+ // (if true) is selected.
+ bool keyword_selected_;
+
// The match the user has manually chosen, if any.
AutocompleteResult::Selection manually_selected_match_;

Powered by Google App Engine
This is Rietveld 408576698