Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc

Issue 6731036: Enabled pressing TAB to cycle through the Omnibox results. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm ('K') | « chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm ('k') | chrome/browser/ui/omnibox/omnibox_view_browsertest.cc » ('j') | chrome/browser/ui/omnibox/omnibox_view_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc
===================================================================
--- chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc (revision 93757)
+++ chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc (working copy)
@@ -476,10 +476,8 @@
// extension, |match| and its contents. So copy the relevant match out to
// make sure it stays alive until the call completes.
AutocompleteMatch match = model_->result().match_at(line);
- string16 keyword;
- const bool is_keyword_hint = model_->GetKeywordForMatch(match, &keyword);
omnibox_view_->OpenMatch(match, disposition, GURL(), line,
- is_keyword_hint ? string16() : keyword);
+ match.keyword);
Peter Kasting 2011/07/27 20:18:25 Nit: Go ahead and indent even
}
GdkPixbuf* OmniboxPopupViewGtk::IconForMatch(const AutocompleteMatch& match,
« chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm ('K') | « chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm ('k') | chrome/browser/ui/omnibox/omnibox_view_browsertest.cc » ('j') | chrome/browser/ui/omnibox/omnibox_view_browsertest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698