Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2044)

Unified Diff: chrome/browser/instant/instant_controller.cc

Issue 6731036: Enabled pressing TAB to cycle through the Omnibox results. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/instant/instant_controller.cc
===================================================================
--- chrome/browser/instant/instant_controller.cc (revision 81359)
+++ chrome/browser/instant/instant_controller.cc (working copy)
@@ -637,7 +637,8 @@
return false;
// Extension keywords don't have a real destionation URL.
Peter Kasting 2011/04/13 21:06:59 Nit: While here, destionation -> destination
- if (match.template_url && match.template_url->IsExtensionKeyword())
+ if (match.keyword_state == AutocompleteMatch::KEYWORD &&
Peter Kasting 2011/04/13 21:06:59 I don't think we need to check the keyword state h
+ match.keyword_url && match.keyword_url->IsExtensionKeyword())
return false;
// Was the host blacklisted?
@@ -674,7 +675,9 @@
const TemplateURL* InstantController::GetTemplateURL(
const AutocompleteMatch& match) {
- const TemplateURL* template_url = match.template_url;
+ const TemplateURL* template_url =
+ match.keyword_state == AutocompleteMatch::KEYWORD ? match.keyword_url :
Peter Kasting 2011/04/13 21:06:59 I think you also want to allow DUAL_SHOWING_KEYWOR
+ NULL;
if (match.type == AutocompleteMatch::SEARCH_WHAT_YOU_TYPED ||
match.type == AutocompleteMatch::SEARCH_HISTORY ||
match.type == AutocompleteMatch::SEARCH_SUGGEST) {

Powered by Google App Engine
This is Rietveld 408576698