Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3973)

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_view.cc

Issue 6731036: Enabled pressing TAB to cycle through the Omnibox results. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/location_bar_view.cc
===================================================================
--- chrome/browser/ui/views/location_bar/location_bar_view.cc (revision 80563)
+++ chrome/browser/ui/views/location_bar/location_bar_view.cc (working copy)
@@ -989,24 +989,8 @@
const views::KeyEvent& event) {
#if defined(OS_WIN)
if (views::FocusManager::IsTabTraversalKeyEvent(event)) {
- if (HasValidSuggestText()) {
- // Return true so that the edit sees the tab and commits the suggestion.
- return true;
- }
- if (keyword_hint_view_->IsVisible() && !event.IsShiftDown()) {
- // Return true so the edit gets the tab event and enters keyword mode.
- return true;
- }
-
- // If the caret is not at the end, then tab moves the caret to the end.
- if (!location_entry_->IsCaretAtEnd())
- return true;
-
- // Tab while showing instant commits instant immediately.
- // Return true so that focus traversal isn't attempted. The edit ends
- // up doing nothing in this case.
- if (location_entry_->model()->AcceptCurrentInstantPreview())
- return true;
+ return location_entry_->model()->popup_model()->IsOpen() ||
+ (keyword_hint_view_->IsVisible() && !event.IsShiftDown());
}
return location_entry_->SkipDefaultKeyEventProcessing(event);

Powered by Google App Engine
This is Rietveld 408576698