Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: chrome/browser/autocomplete/autocomplete_popup_view_mac.mm

Issue 6731036: Enabled pressing TAB to cycle through the Omnibox results. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
===================================================================
--- chrome/browser/autocomplete/autocomplete_popup_view_mac.mm (revision 80868)
+++ chrome/browser/autocomplete/autocomplete_popup_view_mac.mm (working copy)
@@ -542,10 +542,15 @@
// and, by extension, |match| and its contents. So copy the
// relevant strings out to make sure they stay alive until the call
// completes.
+ string16 keyword;
+ bool is_keyword_hint = false;
+
+ if (match.keyword.get()) {
+ keyword = match.keyword->text;
+ is_keyword_hint = match.keyword->is_keyword_hint;
+ }
const AutocompleteMatch& match = model_->result().match_at(row);
const GURL url(match.destination_url);
- string16 keyword;
- const bool is_keyword_hint = model_->GetKeywordForMatch(match, &keyword);
edit_view_->OpenURL(url, disposition, match.transition, GURL(), row,
is_keyword_hint ? string16() : keyword);
}

Powered by Google App Engine
This is Rietveld 408576698