Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4822)

Unified Diff: chrome/browser/autocomplete/autocomplete.cc

Issue 6731036: Enabled pressing TAB to cycle through the Omnibox results. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Enabled pressing TAB to cycle through the Omnibox results, removed moving the caret to the Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/autocomplete.cc
===================================================================
--- chrome/browser/autocomplete/autocomplete.cc (revision 79782)
+++ chrome/browser/autocomplete/autocomplete.cc (working copy)
@@ -641,11 +641,16 @@
}
void AutocompleteResult::SortAndCull(const AutocompleteInput& input) {
+ // Normalize destination URLs
Peter Kasting 2011/04/01 00:09:09 Nit: This comment adds nothing, just eliminate it.
+ for (ACMatches::iterator i = matches_.begin(); i != matches_.end(); ++i) {
Peter Kasting 2011/04/01 00:09:09 Nit: No {}
+ i->NormalizeDestination();
+ }
+
// Remove duplicates.
std::sort(matches_.begin(), matches_.end(),
- &AutocompleteMatch::DestinationSortFunc);
+ &AutocompleteMatch::NormalizedSortFunc);
matches_.erase(std::unique(matches_.begin(), matches_.end(),
- &AutocompleteMatch::DestinationsEqual),
+ &AutocompleteMatch::NormalizedEqual),
matches_.end());
// Sort and trim to the most relevant kMaxMatches matches.

Powered by Google App Engine
This is Rietveld 408576698