Enabled pressing TAB to cycle through the Omnibox results.

chrome/browser/autocomplete/autocomplete_match.h

Index: chrome/browser/autocomplete/autocomplete_match.h
===================================================================
--- chrome/browser/autocomplete/autocomplete_match.h	(revision 95169)
+++ chrome/browser/autocomplete/autocomplete_match.h	(working copy)
@@ -9,6 +9,7 @@
 #include <vector>
 #include <string>
 
+#include "base/memory/scoped_ptr.h"
 #include "content/common/page_transition_types.h"
 #include "googleurl/src/gurl.h"
 
@@ -87,8 +88,11 @@
                     int relevance,
                     bool deletable,
                     Type type);
+  AutocompleteMatch(const AutocompleteMatch& match);
   ~AutocompleteMatch();
 
+  AutocompleteMatch& operator=(const AutocompleteMatch& match);
+
   // Converts |type| to a string representation.  Used in logging.
   static std::string TypeToString(Type type);
 
@@ -101,6 +105,7 @@
                            const AutocompleteMatch& elem2);
 
   // Comparison functions for removing matches with duplicate destinations.
+  // Destinations are compared using |stripped_destination_url|.
   static bool DestinationSortFunc(const AutocompleteMatch& elem1,
                                   const AutocompleteMatch& elem2);
   static bool DestinationsEqual(const AutocompleteMatch& elem1,
@@ -125,6 +130,10 @@
                                        int style,
                                        ACMatchClassifications* classifications);
 
+  // Copies the destination_url with "www." stripped off to
+  // |stripped_destination_url|.
+  void ComputeStrippedDestinationURL();
+
   // The provider of this match, used to remember which provider the user had
   // selected when the input changes. This may be NULL, in which case there is
   // no provider (or memory of the user's selection).
@@ -157,6 +166,9 @@
   // It may be empty if there is no possible navigation.
   GURL destination_url;
 
+  // The destination URL with "www." stripped off for better dupe finding.
+  GURL stripped_destination_url;
+
   // The main text displayed in the address bar dropdown.
   string16 contents;
   ACMatchClassifications contents_class;
@@ -177,6 +189,14 @@
   // Type of this match.
   Type type;
 
+  // Set with a keyword provider match if this match can show a keyword hint.
+  // For example, if this is a SearchProvider match for "www.amazon.com",
+  // |associated_keyword| could be a KeywordProvider match for "amazon.com".
+  scoped_ptr<AutocompleteMatch> associated_keyword;
+
+  // If this is a keyword search match, |keyword| is the keyword text.

[Peter Kasting, 2011/08/04 20:07:53]

Nit: Maybe the explicit "If this match is a keyword provider match, or shows a
keyword hint, ..."?

[aaron.randolph, 2011/08/04 21:02:50]

I don't think that would be accurate because if this match shows a keyword hint
then |associated_keyword| should be set and |keyword| should be blank.

[Peter Kasting, 2011/08/04 21:31:42]

That was what I was asking in my patch set 7 comments.  I thought |keyword| is
set here for anything that is a keyword or shows a keyword hint.  If it's only
set for things that are keywords, why do we need it?  Can't we get that
information from the |template_url| when we know the match is an
|associated_keyword| of another match? 

[aaron.randolph, 2011/08/04 22:32:25]

In the places where |keyword| is used, we don't know that the match is an
|associated_keyword| of another match. Plus, matches in the result set can have
this set; it's not just for associated keywords. It's mainly used as a cache so
that calls such as OpenMatch and OnPopupDataChanged are simpler.  It replaces
calls to GetKeywordText and, in most places, a conditional operator.

[Peter Kasting, 2011/08/04 23:13:16]

It sounds like this member deserves a block comment saying when and how this is
set and what it's used for.  For example,

// For matches that correspond to valid substituting keywords ("search engines"
that aren't the default engine, or extension keywords), this is the keyword.  If
this is set, then when displaying this match, the edit will use the "keyword
mode" UI that shows a blue "Search <engine name>" chit before the user's typing.
 This should be set for any match that's an |associated_keyword| of a match in
the main result list, as well as any other matches in the main result list that
are direct keyword matches (e.g. if the user types in a keyword name and some
search terms directly).

+  string16 keyword;
+
   // Indicates the TemplateURL the match originated from. This is set for
   // keywords as well as matches for the default search provider.
   const TemplateURL* template_url;