Enabled pressing TAB to cycle through the Omnibox results.

chrome/browser/autocomplete/autocomplete_edit.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autocomplete/autocomplete_edit.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/metrics/histogram.h"
@@ skipping 364 matching lines @@
   keyword_.clear();
   is_keyword_hint_ = false;
   has_temporary_text_ = false;
   view_->SetWindowTextAndCaretPos(permanent_text_,
                                   has_focus_ ? permanent_text_.length() : 0);
 }
 
 void AutocompleteEditModel::StartAutocomplete(
     bool has_selected_text,
     bool prevent_inline_autocomplete) const {
+  ResetCurrentMatchKeywordMode();

[Peter Kasting, 2011/04/07 20:19:21]

Your CL must be missing some locally modified files.  This must be declared in
the header but the header isn't up for review.

+
   bool keyword_is_selected = KeywordIsSelected();
   popup_->SetHoveredLine(AutocompletePopupModel::kNoMatch);
   // We don't explicitly clear AutocompletePopupModel::manually_selected_match,
   // as Start ends up invoking AutocompletePopupModel::OnResultChanged which
   // clears it.
   autocomplete_controller_->Start(
       user_text_, GetDesiredTLD(),
       prevent_inline_autocomplete || just_deleted_text_ ||
       (has_selected_text && inline_autocomplete_text_.empty()) ||
       (paste_state_ != NONE), keyword_is_selected,
@@ skipping 146 matching lines @@
 
   InstantController* instant = controller_->GetInstant();
   if (instant && !popup_->IsOpen())
     instant->DestroyPreviewContents();
   update_instant_ = true;
 }
 
 bool AutocompleteEditModel::AcceptKeyword() {
   DCHECK(is_keyword_hint_ && !keyword_.empty());
 
-  view_->OnBeforePossibleChange();
-  view_->SetWindowTextAndCaretPos(string16(), 0);
+  autocomplete_controller_->Stop(false);
   is_keyword_hint_ = false;
-  view_->OnAfterPossibleChange();
-  just_deleted_text_ = false;  // OnAfterPossibleChange() erroneously sets this
-                               // since the edit contents have disappeared.  It
-                               // doesn't really matter, but we clear it to be
-                               // consistent.
+
+  if (popup_->selected_line() != AutocompletePopupModel::kNoMatch) {
+    AutocompleteMatch match = CurrentMatch();
+
+    match.keyword->is_keyword_mode = true;
+    popup_->view()->InvalidateLine(popup_->selected_line());
+  }
+
+  view_->SetUserText(string16(), string16(), false);
+
   UserMetrics::RecordAction(UserMetricsAction("AcceptedKeywordHint"), profile_);
   return true;
 }
 
 void AutocompleteEditModel::ClearKeyword(const string16& visible_text) {
-  view_->OnBeforePossibleChange();
+  autocomplete_controller_->Stop(false);
+  ResetCurrentMatchKeywordMode();
+
   const string16 window_text(keyword_ + visible_text);
-  view_->SetWindowTextAndCaretPos(window_text.c_str(), keyword_.length());
-  keyword_.clear();
-  is_keyword_hint_ = false;
-  view_->OnAfterPossibleChange();
-  just_deleted_text_ = true;  // OnAfterPossibleChange() fails to clear this
-                              // since the edit contents have actually grown
-                              // longer.
+
+  // Only reset the result if the edit text has changed since the
+  // keyword was accepted.
+  if (just_deleted_text_) {
+    view_->SetWindowTextAndCaretPos(window_text.c_str(), keyword_.length());
+    keyword_.clear();
+    is_keyword_hint_ = false;
+    view_->OnAfterPossibleChange();
+    just_deleted_text_ = true;  // OnAfterPossibleChange() fails to clear this
+                                // since the edit contents have actually grown
+                                // longer.
+  } else {
+    view_->SetUserText(window_text, window_text, false);
+
+    if (visible_text.size() != 0) {

[Peter Kasting, 2011/04/07 20:19:21]

Nit: Shorter:

is_keyword_hint_ = visible_text.empty();
if (!is_keyword_hint_)
  keyword.clear();

+      is_keyword_hint_ = false;
+      keyword_.clear();
+    } else {
+      is_keyword_hint_ = true;
+    }
+
+    OnChanged();
+  }
+}
+
+void AutocompleteEditModel::ResetCurrentMatchKeywordMode() const {
+  if (popup_->selected_line() != AutocompletePopupModel::kNoMatch) {
+    AutocompleteMatch match;
+    InfoForCurrentSelection(&match, NULL);
+
+    if (match.keyword.get() && match.keyword->is_keyword_hint &&
+      match.keyword->is_keyword_mode) {
+      match.keyword->is_keyword_mode = false;
+      popup_->view()->InvalidateLine(popup_->selected_line());
+    }
+  }
 }
 
 const AutocompleteResult& AutocompleteEditModel::result() const {
   return autocomplete_controller_->result();
 }
 
 void AutocompleteEditModel::OnSetFocus(bool control_down) {
   has_focus_ = true;
   control_key_state_ = control_down ? DOWN_WITHOUT_CHANGE : UP;
   NotificationService::current()->Notify(
@@ skipping 78 matching lines @@
       if (!user_input_in_progress_)
         InternalSetUserText(permanent_text_);
       view_->UpdatePopup();
     } else {
       // TODO(pkasting): The popup is working on a query but is not open.  We
       // should force it to open immediately.
     }
   } else {
     // The popup is open, so the user should be able to interact with it
     // normally.
+    if (popup_->selected_line() != AutocompletePopupModel::kNoMatch) {
+      AutocompleteMatch match = CurrentMatch();
+
+      if (match.keyword.get() && match.keyword->is_keyword_hint &&
+        match.keyword->is_keyword_mode)
+        ClearKeyword(string16());
+    }
+
     popup_->Move(count);
   }
 }
 
 void AutocompleteEditModel::OnPopupDataChanged(
     const string16& text,
     GURL* destination_for_temporary_text_change,
     const string16& keyword,
     bool is_keyword_hint) {
   // Update keyword/hint-related local state.
@@ skipping 165 matching lines @@
       if (!match->destination_url.SchemeIs(chrome::kExtensionScheme)) {
         // Warm up DNS Prefetch cache, or preconnect to a search service.
         chrome_browser_net::AnticipateOmniboxUrl(match->destination_url,
                                                  IsPreconnectable(match->type));
       }
 
       // We could prefetch the alternate nav URL, if any, but because there
       // can be many of these as a user types an initial series of characters,
       // the OS DNS cache could suffer eviction problems for minimal gain.
 
-      is_keyword_hint = popup_->GetKeywordForMatch(*match, &keyword);
+      if (match->keyword.get()) {
+        is_keyword_hint = match->keyword->is_keyword_hint;
+        keyword = match->keyword->text;
+      }
     }
+
     popup_->OnResultChanged();
     OnPopupDataChanged(inline_autocomplete_text, NULL, keyword,
                        is_keyword_hint);
   } else {
     popup_->OnResultChanged();
   }
 
   if (popup_->IsOpen()) {
     PopupBoundsChangedTo(popup_->view()->GetTargetBounds());
   } else if (was_open) {
@@ skipping 123 matching lines @@
                              old_user_text.length() - caret_position + 1)) {
     return false;
   }
 
   // Then check if the text before the inserted space matches a keyword.
   string16 keyword;
   TrimWhitespace(new_user_text.substr(0, caret_position - 1),
                  TRIM_LEADING, &keyword);
 
   // Only allow exact keyword match if |keyword| represents a keyword hint.
-  return keyword.length() && popup_->GetKeywordForText(keyword, &keyword);
+  return keyword.length() &&
+    autocomplete_controller_->GetKeywordForText(keyword, &keyword);
 }
 
 //  static
 bool AutocompleteEditModel::IsSpaceCharForAcceptingKeyword(wchar_t c) {
   switch (c) {
     case 0x0020:  // Space
     case 0x3000:  // Ideographic Space
       return true;
     default:
       return false;
   }
 }