Enabled pressing TAB to cycle through the Omnibox results.

chrome/browser/autocomplete/autocomplete.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_H_
 #define CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_H_
 #pragma once
 
 #include <map>
 #include <string>
@@ skipping 639 matching lines @@
 
   // Asks the relevant provider to delete |match|, and ensures observers are
   // notified of resulting changes immediately.  This should only be called when
   // no query is running.
   void DeleteMatch(const AutocompleteMatch& match);
 
   // Removes any entries that were copied from the last result. This is used by
   // the popup to ensure it's not showing an out-of-date query.
   void ExpireCopiedEntries();
 
+  // Gets the selected keyword or keyword hint for the given match.

[Peter Kasting, 2011/04/07 20:19:21]

This function claims to be a getter but actually is something that updates the
keyword field on the supplied match.

Since I think this now only has one caller, when the controller wants to set the
keywords on the return result, I suggest simply inlining this functionality into
that loop.

+  void GetKeywordForMatch(AutocompleteMatch* match) const;
+
+  // Gets the selected keyword or keyword hint for the given text. Returns
+  // true if |keyword| represents a keyword hint, or false if |keyword|
+  // represents a selected keyword. (|keyword| will always be set [though

[Peter Kasting, 2011/04/07 20:19:21]

This function now seems to only have two cases: clear |keyword| and return
false, or set it and return true.  I suggest condensing it to just "string16
GetKeywordForText(const string16& text)".

+  // possibly to the empty string], and you cannot have both a selected keyword
+  // and a keyword hint simultaneously.)
+  bool GetKeywordForText(const string16& text, string16* keyword) const;
+
   SearchProvider* search_provider() const { return search_provider_; }
 
   // Getters
   const AutocompleteInput& input() const { return input_; }
   const AutocompleteResult& result() const { return result_; }
   bool done() const { return done_; }
 
   // From AutocompleteProvider::Listener
   virtual void OnProviderUpdate(bool updated_matches);
 
@@ skipping 23 matching lines @@
   // Input passed to Start.
   AutocompleteInput input_;
 
   // Data from the autocomplete query.
   AutocompleteResult result_;
 
   // Timer used to remove any matches copied from the last result. When run
   // invokes |ExpireCopiedEntries|.
   base::OneShotTimer<AutocompleteController> expire_timer_;
 
+  Profile* profile_;
+
   // True if a query is not currently running.
   bool done_;
 
   // Are we in Start()? This is used to avoid updating |result_| and sending
   // notifications until Start() has been invoked on all providers.
   bool in_start_;
 
   DISALLOW_COPY_AND_ASSIGN(AutocompleteController);
 };
 
@@ skipping 19 matching lines @@
   AutocompleteInput::Type input_type;
   // Selected index (if selected) or -1 (AutocompletePopupModel::kNoMatch).
   size_t selected_index;
   // Inline autocompleted length (if displayed).
   size_t inline_autocompleted_length;
   // Result set.
   const AutocompleteResult& result;
 };
 
 #endif  // CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_H_