Refactor generate_test_report for better library usage.

Refactor generate_test_report for better library usage.

In the near future we'll be using generate_test_report to process Autotest directories for e-mail digest. The first step here is making sure the code is reusable in library form.

I've factored out the results collection from the report generation and remove dependencies on the options dictionary in favor of individual variables.

I've also made a performance tweak by moving the pruning of invalid directories further up the chain. After the first level, it's safe to assume every directory we're interested in will have a debug directory in it. Moving this up prunes massive trees of possibilities off.

Change-Id: I3a492e83ad6cfa78a033cc2bd2cae22b91cbb6d4

BUG=chromium-os:13496
TEST=Ran a/b comparisons on several results directories.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=f17623c

[DaleCurtis, 2011-03-31 17:35:30]

Ping!

On 2011/03/24 20:38:11, dalec wrote:

[sosa, 2011-03-31 20:03:34]

Looks nice.  One suggestion, ow LGTM

http://codereview.chromium.org/6731024/diff/6001/utils_py/generate_test_repor...
File utils_py/generate_test_report.py (left):

http://codereview.chromium.org/6731024/diff/6001/utils_py/generate_test_repor...
utils_py/generate_test_report.py:108: return
Why move this into the caller but not the above?  Maybe move both into a
_ShouldFilterResult method that is called from CollectResults

[DaleCurtis, 2011-03-31 20:17:43]

http://codereview.chromium.org/6731024/diff/6001/utils_py/generate_test_repor...
File utils_py/generate_test_report.py (left):

http://codereview.chromium.org/6731024/diff/6001/utils_py/generate_test_repor...
utils_py/generate_test_report.py:108: return
Just checking for the debug directory prunes everything we need to and the above
code introduces variables depended on by the code below.

I could do it by creating two new functions, GetStatusFile and
IsValidResultsDirectory, but there'd still be two calls to GetStatusFile unless
I pass in the status file which seems confusing.

On 2011/03/31 20:03:34, sosa wrote:
> Why move this into the caller but not the above?  Maybe move both into a
> _ShouldFilterResult method that is called from CollectResults

[sosa, 2011-03-31 20:31:21]

That sounds fine.  LGTM

On Thu, Mar 31, 2011 at 1:17 PM,  <dalecurtis@chromium.org> wrote:
>
>
http://codereview.chromium.org/6731024/diff/6001/utils_py/generate_test_repor...
> File utils_py/generate_test_report.py (left):
>
>
http://codereview.chromium.org/6731024/diff/6001/utils_py/generate_test_repor...
> utils_py/generate_test_report.py:108: return
> Just checking for the debug directory prunes everything we need to and
> the above code introduces variables depended on by the code below.
>
> I could do it by creating two new functions, GetStatusFile and
> IsValidResultsDirectory, but there'd still be two calls to GetStatusFile
> unless I pass in the status file which seems confusing.
>
> On 2011/03/31 20:03:34, sosa wrote:
>>
>> Why move this into the caller but not the above?  Maybe move both into
>
> a
>>
>> _ShouldFilterResult method that is called from CollectResults
>
> http://codereview.chromium.org/6731024/
>