Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 6730047: crosutils: remove some unused scripts (Closed)

Created:
9 years, 9 months ago by zbehan
Modified:
9 years, 7 months ago
Reviewers:
kmixter1, gauravsh, anush
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

crosutils: remove some unused scripts BUG=13499 TEST=none Change-Id: I2f2475d4334e058d8ddefc80dbbe8dff6ceb88ad R=anush@chromium.org,kmixter@chromium.org,gauravsh@chromium.org Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=2ecf7d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -958 lines) Patch
D image_hacks.sh View 1 chunk +0 lines, -145 lines 0 comments Download
D image_to_virtualbox.sh View 1 chunk +0 lines, -63 lines 0 comments Download
D sync_build_test.sh View 1 chunk +0 lines, -750 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
zbehan
9 years, 9 months ago (2011-03-25 01:20:27 UTC) #1
anush
LGTM. +tbroch On Thu, Mar 24, 2011 at 6:20 PM, <zbehan@chromium.org> wrote: > Reviewers: anush, ...
9 years, 9 months ago (2011-03-25 01:27:56 UTC) #2
kmixter1
it's a sad day. s/unused/no longer tolerated/. I will continue to use sync_build_test daily until ...
9 years, 9 months ago (2011-03-25 04:45:16 UTC) #3
gauravsh
I don't use any of these scripts, so LGTM. (BTW, if you are listing multiple ...
9 years, 9 months ago (2011-03-25 05:01:58 UTC) #4
zbehan
Sorry. I'll put it back. On Fri, Mar 25, 2011 at 5:44 AM, Ken Mixter ...
9 years, 9 months ago (2011-03-25 07:49:33 UTC) #5
anush
From the chromite/buildbot dir you can run ./cbuildbot --buildroot=somedir --debug x86-generic-pre-flight-queue Please dont forget the ...
9 years, 9 months ago (2011-03-25 14:27:26 UTC) #6
anush
I had cleared sync_build_test with both kmixter/tbroch (the only users of sync_build_test), and the suggestion ...
9 years, 9 months ago (2011-03-25 14:40:53 UTC) #7
sosa
9 years, 9 months ago (2011-03-25 19:35:59 UTC) #8
Don is working on making cbuildbot more developer friendly.  As it
does fill all the use cases of sync_build_test, maybe we should just
hold back on removing the latter until the former has a nicer
interface :).

As for the cbuildbot interface ... add --nouprev for more of the
sync_build_test use case.

On Fri, Mar 25, 2011 at 7:40 AM, Anush Elangovan(அனுஷ்)
<anush@chromium.org> wrote:
> I had cleared sync_build_test with both kmixter/tbroch (the only users of
> sync_build_test), and the suggestion was to keep any custom wrapper scripts
> out of crosutils and use a generic interface built around cbuildbot which is
> becoming our "trybot" interface.
> Even if we needed another custom wrapper script to help particular workflows
> (if we can't add it to cbuildbot) we should put it in dev-utils and not put
> sync_build_test back in crosutils, since crosutils is being deprecated
> (slowly).
> Thanks
>
> On Fri, Mar 25, 2011 at 12:49 AM, Zdenek Behan <zbehan@chromium.org> wrote:
>>
>> Sorry. I'll put it back.
>>
>> On Fri, Mar 25, 2011 at 5:44 AM, Ken Mixter <kmixter@chromium.org> wrote:
>>>
>>> it's a sad day.  s/unused/no longer tolerated/.  I will continue to
>>> use sync_build_test daily until I see a viable replacement.
>>>
>>> 2011/3/24 Anush Elangovan(அனுஷ்) <anush@chromium.org>:
>>> > LGTM.
>>> > +tbroch
>>> >
>>> > On Thu, Mar 24, 2011 at 6:20 PM, <zbehan@chromium.org> wrote:
>>> >>
>>> >> Reviewers: anush, kmixter1, gauravsh,
>>> >>
>>> >> Description:
>>> >> crosutils: remove some unused scripts
>>> >>
>>> >> BUG=13499
>>> >> TEST=none
>>> >>
>>> >> Change-Id: I2f2475d4334e058d8ddefc80dbbe8dff6ceb88ad
>>> >>
>>> >> R=anush@chromium.org,kmixter@chromium.org,gauravsh@chromium.org
>>> >>
>>> >>
>>> >> Please review this at http://codereview.chromium.org/6730047/
>>> >>
>>> >> SVN Base: ssh://git@gitrw.chromium.org:9222/crosutils.git@master
>>> >>
>>> >> Affected files:
>>> >>  D image_hacks.sh
>>> >>  D image_to_virtualbox.sh
>>> >>  D sync_build_test.sh
>>> >>
>>> >>
>>> >
>>> >
>>
>
>

Powered by Google App Engine
This is Rietveld 408576698