Issue 6730025: Fix bug that caused invalid code motion for certain loads instructions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6730025: Fix bug that caused invalid code motion for certain loads instructions. (Closed)

Created:
9 years, 9 months ago by fschneider

Modified:
9 years, 6 months ago

Reviewers:
Kevin Millikin (Chromium), Vitaly Repeshko

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix bug that caused invalid code motion for certain loads instructions. The dependency flags of instructions depending on a previous check have to be a super-set of the flags of the check instructions. Committed: http://code.google.com/p/v8/source/detail?r=7343

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -2 lines)			Patch
	M	src/hydrogen-instructions.h	View		6 chunks	+7 lines, -2 lines	0 comments	Download
	A	test/mjsunit/compiler/regress-loadfield.js	View		1 chunk	+65 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages