Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/ui_test_utils.h

Issue 6730016: Fix flakiness and enable RenderViewHostManagerTest on Linux/Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix additional flakiness. Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/test/plugin/pdf_browsertest.cc ('K') | « chrome/test/plugin/pdf_browsertest.cc ('k') | chrome/test/ui_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/ui_test_utils.h
diff --git a/chrome/test/ui_test_utils.h b/chrome/test/ui_test_utils.h
index c896dc4a9e43b752a4eacc383fa298290078e002..cb5a03beea5af3fadc99fef54421dd65aefb8743 100644
--- a/chrome/test/ui_test_utils.h
+++ b/chrome/test/ui_test_utils.h
@@ -109,8 +109,9 @@ void WaitForNewTab(Browser* browser);
// Waits for a |browser_action| to be updated.
void WaitForBrowserActionUpdated(ExtensionAction* browser_action);
-// Waits for a load stop for the specified |controller|.
-void WaitForLoadStop(NavigationController* controller);
+// Waits for a load stop for the specified |tab|'s controller, if the tab is
+// currently loading.
Paweł Hajdan Jr. 2011/03/25 09:39:42 nit: Please either remove the "if the tab is curre
Charlie Reis 2011/03/25 19:46:03 Done (and landed).
+void WaitForLoadStop(TabContents* tab);
// Waits for a new browser to be created, returning the browser.
Browser* WaitForNewBrowser();
« chrome/test/plugin/pdf_browsertest.cc ('K') | « chrome/test/plugin/pdf_browsertest.cc ('k') | chrome/test/ui_test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698