Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Side by Side Diff: chrome/browser/ssl/ssl_browser_tests.cc

Issue 6730016: Fix flakiness and enable RenderViewHostManagerTest on Linux/Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix additional flakiness. Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/time.h" 5 #include "base/time.h"
6 #include "chrome/app/chrome_command_ids.h" 6 #include "chrome/app/chrome_command_ids.h"
7 #include "chrome/browser/tabs/tab_strip_model.h" 7 #include "chrome/browser/tabs/tab_strip_model.h"
8 #include "chrome/browser/ui/browser.h" 8 #include "chrome/browser/ui/browser.h"
9 #include "chrome/browser/ui/browser_navigator.h" 9 #include "chrome/browser/ui/browser_navigator.h"
10 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" 10 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
11 #include "chrome/test/in_process_browser_test.h" 11 #include "chrome/test/in_process_browser_test.h"
(...skipping 395 matching lines...) Expand 10 before | Expand all | Expand 10 after
407 // Open a page with a HTTPS error in a tab with no prior navigation (through a 407 // Open a page with a HTTPS error in a tab with no prior navigation (through a
408 // link with a blank target). This is to test that the lack of navigation entry 408 // link with a blank target). This is to test that the lack of navigation entry
409 // does not cause any problems (it was causing a crasher, see 409 // does not cause any problems (it was causing a crasher, see
410 // http://crbug.com/19941). 410 // http://crbug.com/19941).
411 IN_PROC_BROWSER_TEST_F(SSLUITest, TestHTTPSErrorWithNoNavEntry) { 411 IN_PROC_BROWSER_TEST_F(SSLUITest, TestHTTPSErrorWithNoNavEntry) {
412 ASSERT_TRUE(https_server_expired_.Start()); 412 ASSERT_TRUE(https_server_expired_.Start());
413 413
414 GURL url = https_server_expired_.GetURL("files/ssl/google.htm"); 414 GURL url = https_server_expired_.GetURL("files/ssl/google.htm");
415 TabContentsWrapper* tab2 = 415 TabContentsWrapper* tab2 =
416 browser()->AddSelectedTabWithURL(url, PageTransition::TYPED); 416 browser()->AddSelectedTabWithURL(url, PageTransition::TYPED);
417 ui_test_utils::WaitForLoadStop(&(tab2->controller())); 417 ui_test_utils::WaitForLoadStop(tab2->tab_contents());
418 418
419 // Verify our assumption that there was no prior navigation. 419 // Verify our assumption that there was no prior navigation.
420 EXPECT_FALSE(browser()->command_updater()->IsCommandEnabled(IDC_BACK)); 420 EXPECT_FALSE(browser()->command_updater()->IsCommandEnabled(IDC_BACK));
421 421
422 // We should have an interstitial page showing. 422 // We should have an interstitial page showing.
423 ASSERT_TRUE(tab2->tab_contents()->interstitial_page()); 423 ASSERT_TRUE(tab2->tab_contents()->interstitial_page());
424 } 424 }
425 425
426 // 426 //
427 // Insecure content 427 // Insecure content
(...skipping 667 matching lines...) Expand 10 before | Expand all | Expand 10 after
1095 1095
1096 // Visit a page over https that contains a frame with a redirect. 1096 // Visit a page over https that contains a frame with a redirect.
1097 1097
1098 // XMLHttpRequest insecure content in synchronous mode. 1098 // XMLHttpRequest insecure content in synchronous mode.
1099 1099
1100 // XMLHttpRequest insecure content in asynchronous mode. 1100 // XMLHttpRequest insecure content in asynchronous mode.
1101 1101
1102 // XMLHttpRequest over bad ssl in synchronous mode. 1102 // XMLHttpRequest over bad ssl in synchronous mode.
1103 1103
1104 // XMLHttpRequest over OK ssl in synchronous mode. 1104 // XMLHttpRequest over OK ssl in synchronous mode.
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698