Issue 6730012: Remove testing utilities and fix symlinks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6730012: Remove testing utilities and fix symlinks. (Closed)

Created:
9 years, 9 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git@master

Visibility:
Public.

Description

Remove testing utilities and fix symlinks. For run_remote_tests this required "fixing" restart_in_chroot if required. Right now that script ->only<- works if its run on a scripts being called from src/scripts. This change makes it more generic by doing this for any script called from within our source tree. I borrow reinterpret_path_for_chroot from image_to_live. Other CL to remove it from there. Change-Id: If717beccd777ac178366d58b91521b9a62d55d85 BUG=chromium-os:11172 TEST=Ran them Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=fd2cdec

Patch Set 1 #

Patch Set 2 : Fix common #

Total comments: 2

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -1223 lines)			Patch
M	bin/cros_run_parallel_vm_tests	View		1 chunk	+1 line, -1 line	0 comments	Download
D	bin/cros_run_parallel_vm_tests.py	View		1 chunk	+0 lines, -175 lines	0 comments	Download
A	bin/cros_run_vm_test	View		1 chunk	+0 lines, -110 lines	0 comments	Download
	bin/cros_run_vm_test	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	bin/cros_run_vm_update	View		1 chunk	+0 lines, -79 lines	0 comments	Download
	bin/cros_run_vm_update	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	common.sh	View	1	2 chunks	+31 lines, -4 lines	2 comments	Download
A	cros_run_unit_tests	View		1 chunk	+0 lines, -132 lines	0 comments	Download
	cros_run_unit_tests	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	generate_test_report	View		1 chunk	+1 line, -1 line	0 comments	Download
D	generate_test_report.py	View		1 chunk	+0 lines, -327 lines	0 comments	Download
A	run_remote_tests.sh	View		1 chunk	+0 lines, -340 lines	0 comments	Download
	run_remote_tests.sh	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	ssh_test.sh	View		1 chunk	+0 lines, -54 lines	0 comments	Download
	ssh_test.sh	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

petkov

9 years, 9 months ago (2011-03-24 03:35:17 UTC) #2

A couple of nits, LGTM otherwise (assuming all these broken diffs are just
symlink replacements)

http://codereview.chromium.org/6730012/diff/1015/common.sh
File common.sh (right):

http://codereview.chromium.org/6730012/diff/1015/common.sh#newcode311
common.sh:311: "$chroot_path" "$@"
move this up?

http://codereview.chromium.org/6730012/diff/1015/common.sh#newcode712
common.sh:712: | sed s:${gclient_root_abs_path}/::)
move | up

Expand Messages | Collapse Messages