Base: A few more files using BASE_API (for base.dll)

Base: A few more files using BASE_API (for base.dll)

BUG=76996
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79303

[wtc, 2011-03-23 22:10:25]

LGTM.  Thanks.

I'm counting on you to do the due diligence of verifying
that the functions and classes marked with BASE_API are
truly being used by code outside src/base.

Ideally we should move such headers to a src/base/public
or src/base/api directory to make it harder for external
code to include base-internal headers.  But that'll require
a lot of changes so I won't ask you to do that.

[rvargas (doing something else), 2011-03-23 23:11:12]

On 2011/03/23 22:10:25, wtc wrote:
> LGTM.  Thanks.
> 
> I'm counting on you to do the due diligence of verifying
> that the functions and classes marked with BASE_API are
> truly being used by code outside src/base.
> 
> Ideally we should move such headers to a src/base/public
> or src/base/api directory to make it harder for external
> code to include base-internal headers.  But that'll require
> a lot of changes so I won't ask you to do that.

Thanks for the review.

I'm really not trying to check that everything on base really belongs to base.
That's one of the problems of having a base folder: the risk of people writing
"general purpose code" that is only used once or not at all.

I think that by definition base is "public" by default... so if there are things
that should not be exposed they should be explicitly marked as such.

To be totally honest, the extent of the base.dll project is to be able to have a
tool for faster development and testing, obviously without introducing bugs, but
not particularly focused on performance or small duplication of code.

That said, there is opportunity for cleanup, as it is clear to me that some
parts of the code in base should not be part of this module.