Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2287)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: presubmit_canned_checks.py

Issue 6728031: Make owners check optional. (Closed) Base URL: svn://chrome-svn/chrome/trunk/tools/depot_tools/
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: presubmit_canned_checks.py
===================================================================
--- presubmit_canned_checks.py (revision 80028)
+++ presubmit_canned_checks.py (working copy)
@@ -838,7 +838,8 @@
def PanProjectChecks(input_api, output_api,
excluded_paths=None, text_files=None,
- license_header=None, project_name=None):
+ license_header=None, project_name=None,
+ owners_check=True):
"""Checks that ALL chromium orbit projects should use.
These are checks to be run on all Chromium orbit project, including:
@@ -884,8 +885,9 @@
text_files = lambda x: input_api.FilterSourceFile(x, black_list=black_list,
white_list=white_list)
- results.extend(input_api.canned_checks.CheckOwners(
- input_api, output_api, source_file_filter=sources))
+ if owners_check:
+ results.extend(input_api.canned_checks.CheckOwners(
+ input_api, output_api, source_file_filter=sources))
results.extend(input_api.canned_checks.CheckLongLines(
input_api, output_api, source_file_filter=sources))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698