Issue 6727027: Update protobuf definitions for ChromeOS device policy support

Issue 6727027: Update protobuf definitions for ChromeOS device policy support (Closed)

Created:
9 years, 9 months ago by Jakob Kummerow

Modified:
9 years, 6 months ago

Reviewers:
gfeher

CC:
chromium-reviews, Paweł Hajdan Jr., Chris Masone

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Update protobuf definitions for ChromeOS device policy support BUG=chromium-os:11258 TEST=compiles; existing unit tests pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79390

Patch Set 2 : address comments #

Total comments: 2

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -21 lines)			Patch
M	chrome/app/policy/cloud_policy_codegen.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/cloud_policy_cache.cc	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/policy/cloud_policy_cache_unittest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/policy/cloud_policy_controller.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/policy/mock_device_management_backend.h	View		1 chunk	+1 line, -1 line	2 comments	Download
A	chrome/browser/policy/proto/chrome_device_policy.proto	View	1	1 chunk	+38 lines, -0 lines	0 comments	Download
M	chrome/browser/policy/proto/device_management_backend.proto	View	1	4 chunks	+23 lines, -11 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

Gábor: Please take a look. These are the same changes as we did for the ...

9 years, 9 months ago (2011-03-23 18:13:57 UTC) #1

gfeher

http://codereview.chromium.org/6727027/diff/1/chrome/browser/policy/cloud_policy_cache.cc File chrome/browser/policy/cloud_policy_cache.cc (right): http://codereview.chromium.org/6727027/diff/1/chrome/browser/policy/cloud_policy_cache.cc#newcode314 chrome/browser/policy/cloud_policy_cache.cc:314: // Will do proper cleanup in my next CL. ...

9 years, 9 months ago (2011-03-24 12:16:56 UTC) #2

Jakob Kummerow

9 years, 9 months ago (2011-03-24 16:09:51 UTC) #3

gfeher

LGTM http://codereview.chromium.org/6727027/diff/1/chrome/chrome_browser.gypi File chrome/chrome_browser.gypi (right): http://codereview.chromium.org/6727027/diff/1/chrome/chrome_browser.gypi#newcode3281 chrome/chrome_browser.gypi:3281: ['exclude', '<(protoc_out_dir)/chrome/browser/policy/proto/chrome_device_policy.pb.'], As discussed, please add '*'. http://codereview.chromium.org/6727027/diff/5001/chrome/browser/policy/mock_device_management_backend.h ...

9 years, 9 months ago (2011-03-24 18:00:22 UTC) #4

Jakob Kummerow

9 years, 9 months ago (2011-03-25 13:11:49 UTC) #5

For the record: nits fixed and CL landed.

http://codereview.chromium.org/6727027/diff/1/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/6727027/diff/1/chrome/chrome_browser.gypi#newc...
chrome/chrome_browser.gypi:3281: ['exclude',
'<(protoc_out_dir)/chrome/browser/policy/proto/chrome_device_policy.pb.'],
On 2011/03/24 18:00:22, gfeher wrote:
> As discussed, please add '*'.

Done.

http://codereview.chromium.org/6727027/diff/5001/chrome/browser/policy/mock_d...
File chrome/browser/policy/mock_device_management_backend.h (left):

http://codereview.chromium.org/6727027/diff/5001/chrome/browser/policy/mock_d...
chrome/browser/policy/mock_device_management_backend.h:96: // implementing
support for signature verification).
On 2011/03/24 18:00:22, gfeher wrote:
> No need for one more review roundtrip after you change this, as you've
> mentioned.

Done.

Expand Messages | Collapse Messages