Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: webkit/appcache/appcache_host.h

Issue 6727006: Select a more appropiate appcache based on the opener or the parent of the new document. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/appcache/appcache_host.h
===================================================================
--- webkit/appcache/appcache_host.h (revision 80669)
+++ webkit/appcache/appcache_host.h (working copy)
@@ -71,6 +71,16 @@
void SwapCacheWithCallback(SwapCacheCallback* callback,
void* callback_param);
+ // Called prior to the main resource load. When the system contains multiple
+ // candidates for a main resource load, the appcache preferred by the host
+ // that created this host is used to break ties.
jennb 2011/04/12 00:07:56 indentation
michaeln 2011/04/14 23:41:23 Done.
+ void SetSpawningHostId(int spawning_process_id, int spawning_host_id);
+ AppCacheHost* GetSpawningHost();
adamk 2011/04/11 20:45:16 Can this be a const AppChacheHost*? I think you s
+ const GURL& preferred_manifest_url() { return preferred_manifest_url_; }
adamk 2011/04/11 20:45:16 You can make this a const method.
michaeln 2011/04/14 23:41:23 Done.
+ void set_preferred_manifest_url(const GURL& url) {
+ preferred_manifest_url_ = url;
+ }
+
// Support for loading resources out of the appcache.
// May return NULL if the request isn't subject to retrieval from an appache.
AppCacheRequestHandler* CreateRequestHandler(
@@ -149,6 +159,13 @@
// Identifies the corresponding appcache host in the child process.
int host_id_;
+ // Information about the host that created this one, the manifest
jennb 2011/04/12 00:07:56 nit: replace comma with semicolon
michaeln 2011/04/14 23:41:23 Done.
+ // preferred by our creator influences which cache our main resource
+ // should be loaded from.
+ int spawning_host_id_;
+ int spawning_process_id_;
+ GURL preferred_manifest_url_;
+
// Hosts for dedicated workers are special cased to shunt
// request handling off to the dedicated worker's parent.
// The scriptable api is not accessible in dedicated workers

Powered by Google App Engine
This is Rietveld 408576698