Select a more appropiate appcache based on the opener or the parent of the new document.

webkit/appcache/appcache_host.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_APPCACHE_APPCACHE_HOST_H_
 #define WEBKIT_APPCACHE_APPCACHE_HOST_H_
 
 #include "base/callback.h"
 #include "base/gtest_prod_util.h"
 #include "base/memory/ref_counted.h"
@@ skipping 53 matching lines @@
   void SelectCacheForSharedWorker(int64 appcache_id);
   void MarkAsForeignEntry(const GURL& document_url,
                           int64 cache_document_was_loaded_from);
   void GetStatusWithCallback(GetStatusCallback* callback,
                              void* callback_param);
   void StartUpdateWithCallback(StartUpdateCallback* callback,
                                void* callback_param);
   void SwapCacheWithCallback(SwapCacheCallback* callback,
                              void* callback_param);
 
+  // Called prior to the main resource load. When the system contains multiple
+  // candidates for a main resource load, the appcache preferred by the host
+  //  that created this host is used to break ties.

[jennb, 2011/04/12 00:07:56]

indentation

[michaeln, 2011/04/14 23:41:23]

Done.

+  void SetSpawningHostId(int spawning_process_id, int spawning_host_id);
+  AppCacheHost* GetSpawningHost();

[adamk, 2011/04/11 20:45:16]

Can this be a const AppChacheHost*?  I think you should have a comment for this
method noting under what conditions it returns NULL.

+  const GURL& preferred_manifest_url() { return preferred_manifest_url_; }

[adamk, 2011/04/11 20:45:16]

You can make this a const method.

[michaeln, 2011/04/14 23:41:23]

Done.

+  void set_preferred_manifest_url(const GURL& url) {
+    preferred_manifest_url_ = url;
+  }
+
   // Support for loading resources out of the appcache.
   // May return NULL if the request isn't subject to retrieval from an appache.
   AppCacheRequestHandler* CreateRequestHandler(
       net::URLRequest* request, ResourceType::Type resource_type);
 
   // Support for devtools inspecting appcache resources.
   void GetResourceList(std::vector<AppCacheResourceInfo>* resource_infos);
 
   // Establishes an association between this host and a cache. 'cache' may be
   // NULL to break any existing association. Associations are established
@@ skipping 58 matching lines @@
     return parent_host_id_ != kNoHostId;
   }
 
   // Returns the parent context's host instance. This is only valid
   // to call when this instance is_for_dedicated_worker.
   AppCacheHost* GetParentAppCacheHost() const;
 
   // Identifies the corresponding appcache host in the child process.
   int host_id_;
 
+  // Information about the host that created this one, the manifest

[jennb, 2011/04/12 00:07:56]

nit: replace comma with semicolon

[michaeln, 2011/04/14 23:41:23]

Done.

+  // preferred by our creator influences which cache our main resource
+  // should be loaded from.
+  int spawning_host_id_;
+  int spawning_process_id_;
+  GURL preferred_manifest_url_;
+
   // Hosts for dedicated workers are special cased to shunt
   // request handling off to the dedicated worker's parent.
   // The scriptable api is not accessible in dedicated workers
   // so the other aspects of this class are not relevant for
   // these special case instances.
   int parent_host_id_;
   int parent_process_id_;
 
   // The cache associated with this host, if any.
   scoped_refptr<AppCache> associated_cache_;
@@ skipping 69 matching lines @@
   FRIEND_TEST_ALL_PREFIXES(AppCacheHostTest, SetSwappableCache);
   FRIEND_TEST_ALL_PREFIXES(AppCacheHostTest, ForDedicatedWorker);
   FRIEND_TEST_ALL_PREFIXES(AppCacheGroupTest, QueueUpdate);
 
   DISALLOW_COPY_AND_ASSIGN(AppCacheHost);
 };
 
 }  // namespace appcache
 
 #endif  // WEBKIT_APPCACHE_APPCACHE_HOST_H_