Issue 67262: Add a "read" extension to the shell programs. This global function...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 67262: Add a "read" extension to the shell programs. This global function... (Closed)

Created:
11 years, 8 months ago by iposva

Modified:
9 years, 4 months ago

Reviewers:
Søren Thygesen Gjesse, Mikhail Naganov

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add a "read" extension to the shell programs. This global function reads the contents of a file into a string and returns it. Committed: http://code.google.com/p/v8/source/detail?r=1741

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -0 lines)			Patch
M	samples/shell.cc	View	1	3 chunks	+22 lines, -0 lines	0 comments	Download
M	src/d8.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/d8.cc	View		3 chunks	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mikhail Naganov

LGTM Thanks for doing this! I'll use it immediately for my tickprocessor rewrite. http://codereview.chromium.org/67262/diff/1/2 File ...

11 years, 8 months ago (2009-04-17 20:46:17 UTC) #2

iposva

11 years, 8 months ago (2009-04-17 20:54:45 UTC) #3

http://codereview.chromium.org/67262/diff/1/2
File samples/shell.cc (right):

http://codereview.chromium.org/67262/diff/1/2#newcode142
Line 142: // function is called.  Loadsits argument file into a JavaScript
string.
On 2009/04/17 20:46:17, Mikhail Naganov wrote:
> Nit: missing space in "Loadsits"

Comment rewritten.

Expand Messages | Collapse Messages