Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 6726050: Build and pass all tests on FreeBSD. (Closed)

Created:
9 years, 9 months ago by Ben Laurie (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Build and pass all tests on FreeBSD. Committed: http://code.google.com/p/v8/source/detail?r=7397

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 10

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -111 lines) Patch
M src/platform-freebsd.cc View 1 2 3 7 chunks +164 lines, -111 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Vitaly Repeshko
http://codereview.chromium.org/6726050/diff/5001/src/platform-freebsd.cc File src/platform-freebsd.cc (right): http://codereview.chromium.org/6726050/diff/5001/src/platform-freebsd.cc#newcode639 src/platform-freebsd.cc:639: const pthread *vm_tid() const { return vm_tid_; } I ...
9 years, 9 months ago (2011-03-28 12:02:30 UTC) #1
Ben Laurie (Chromium)
http://codereview.chromium.org/6726050/diff/5001/src/platform-freebsd.cc File src/platform-freebsd.cc (right): http://codereview.chromium.org/6726050/diff/5001/src/platform-freebsd.cc#newcode639 src/platform-freebsd.cc:639: const pthread *vm_tid() const { return vm_tid_; } On ...
9 years, 9 months ago (2011-03-28 12:08:41 UTC) #2
Vitaly Repeshko
LGTM
9 years, 9 months ago (2011-03-28 12:21:48 UTC) #3
ry
Can this be merged into the 3.1 branch?
9 years, 9 months ago (2011-03-28 20:54:04 UTC) #4
Mads Ager (chromium)
On 2011/03/28 20:54:04, ry wrote: > Can this be merged into the 3.1 branch? Patch ...
9 years, 9 months ago (2011-03-29 06:18:55 UTC) #5
Mads Ager (chromium)
9 years, 9 months ago (2011-03-29 06:40:50 UTC) #6
On 2011/03/29 06:18:55, Mads Ager wrote:
> On 2011/03/28 20:54:04, ry wrote:
> > Can this be merged into the 3.1 branch?
> 
> Patch landed. Will merge to 3.1 branch.

The 3.1 branch does not have isolates so it is not a clean merge. I can't test
this, so I will not merge to the 3.1 branch. If someone has a FreeBSD setup and
wants to merge and fix this patch for the branch, please do and upload a patch.

Thanks,    -- Mads

Powered by Google App Engine
This is Rietveld 408576698