Issue 6726045: verity: fix valgrind warnings in OddLeafCount

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6726045: verity: fix valgrind warnings in OddLeafCount (Closed)

Created:
9 years, 9 months ago by Mandeep Singh Baines

Modified:
9 years, 7 months ago

Reviewers:
Will Drewry, Paul T

CC:
chromium-os-reviews_chromium.org

Base URL:
http://git.chromium.org/git/dm-verity.git@master

Visibility:
Public.

Description

verity: fix valgrind warnings in OddLeafCount We don't clear the end bits (non-hash) of the last block. This results in uninitialized bits being factored into the root hash. This causes test flakiness. Fix by memset all leaf blocks after allocation. BUG=none TEST=Ran OddLeafCount with valgrind. Change-Id: I626f1ab386a67d0da8dcaff40d25245bfc747994 R=taysom@chromium.org,wad@chromium.org Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=08c5dc5

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	dm-bht.c	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages