Issue 6726039: cros_workon: fix common.sh check

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6726039: cros_workon: fix common.sh check (Closed)

Created:
9 years, 9 months ago by Mandeep Singh Baines

Modified:
9 years, 7 months ago

Reviewers:
petkov, jrbarnette, anush

CC:
chromium-os-reviews_chromium.org

Base URL:
http://git.chromium.org/git/dev-util.git@master

Visibility:
Public.

Description

cros_workon: fix common.sh check Error message not necessary since you already get an error message from bash. BUG=none TEST=see below $ ./cros_workon ./cros_workon: line 13: /usr/lib/crosutils/common.sh: No such file or directory $ ./cros_workon_make ./cros_workon_make: line 10: /usr/lib/crosutils/common.sh: No such file or directory Change-Id: I2087d77876376af9ccb497d0a67c354af281c007 R=petkov@chromium.org,anush@chromium.org Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=e7c5ea1

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	host/cros_workon	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	host/cros_workon_make	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jrbarnette

LGTM! For the record, I note that this bug is replicated numerous times in src/scripts. ...

9 years, 9 months ago (2011-03-25 21:48:34 UTC) #2

LGTM

Expand Messages | Collapse Messages