Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 6726018: verity: remove BUG_ON alignment check (Closed)

Created:
9 years, 9 months ago by Mandeep Singh Baines
Modified:
9 years, 7 months ago
Reviewers:
ojn, Olof Johansson, Will Drewry
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

verity: remove BUG_ON alignment check The buffer passed to the compute_hash needs to be aligned when dm-bht.c is used in the kernel. dm-bht.c is also used by the dm-verity user-space code where you don't need aligned buffers. Remove the BUG_ON for now. Eventually, re-enable once we've modified the user-space code to use aligned buffers (or once we stop use common code). BUG=none TEST=Ran unittests. Change-Id: I854c785bcff6994612c373a783fff6bdc93c2afa R=ojn@chromium.org,wad@chromium.org Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=6605c2e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M dm-bht.c View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mandeep Singh Baines
9 years, 9 months ago (2011-03-23 03:25:31 UTC) #1
Olof Johansson
9 years, 9 months ago (2011-03-23 03:28:29 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698