Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 6725042: Forcibly uses a non-standard port for local svn and git servers. (Closed)

Created:
9 years, 9 months ago by M-A Ruel
Modified:
9 years, 7 months ago
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

Forcibly uses a non-standard port for local svn and git servers. This reduces the likehood of conflict with local server and makes possible to run this check two times in parallel. R=dpranke@chromium.org TEST=moar unit tests BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79281

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix presubmit checks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -77 lines) Patch
M gcl.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M tests/fake_repos.py View 7 chunks +83 lines, -55 lines 0 comments Download
M tests/gcl_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/gclient_smoketest.py View 1 4 chunks +28 lines, -20 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
M-A Ruel
9 years, 9 months ago (2011-03-23 19:09:54 UTC) #1
Dirk Pranke
LGTM. http://codereview.chromium.org/6725042/diff/1/tests/gclient_smoketest.py File tests/gclient_smoketest.py (right): http://codereview.chromium.org/6725042/diff/1/tests/gclient_smoketest.py#newcode145 tests/gclient_smoketest.py:145: """Doesn't require neither svnserve nor git-daemon.""" Nit: "Doesn't ...
9 years, 9 months ago (2011-03-23 22:20:41 UTC) #2
commit-bot: I haz the power
9 years, 9 months ago (2011-03-24 15:35:32 UTC) #3
Running presubmit hooks...
** Presubmit ERRORS **
2 unit tests failed.

***************
Test 'tests.gclient_scm_test' failed with code 1

...........EE...................
======================================================================
ERROR: testUpdateUnstagedConflict (__main__.GitWrapperTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/mnt/data/b/commit-queue/workdir/depot_tools/tests/gclient_scm_test.py",
line 757, in testUpdateUnstagedConflict
    scm.update(options, (), [])
  File "/mnt/data/b/commit-queue/workdir/depot_tools/gclient_scm.py", line 363,
in update
    raise gclient_utils.Error(e.stderr)
Error: error: Your local changes to 'b' would be overwritten by merge. 
Aborting.
Please, commit your changes or stash them before you can merge.


======================================================================
ERROR: testUpdateUnstagedConflict (__main__.GitWrapperTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/mnt/data/b/commit-queue/workdir/depot_tools/tests/gclient_scm_test.py",
line 539, in tearDown
    StdoutCheck.tearDown(self)
  File "super_mox.py", line 101, in tearDown
    self.assertEquals('', sys.stdout.getvalue())
AssertionError: '' != '\n_____ . at refs/heads/master\n'

----------------------------------------------------------------------
Ran 31 tests in 1.120s

FAILED (errors=2)


Test 'tests.gclient_smoketest' failed with code 1

.......F..............................
======================================================================
FAIL: testMultiSolutionsJobs (__main__.GClientSmokeBoth)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/mnt/data/b/commit-queue/workdir/depot_tools/tests/gclient_smoketest.py", line
966, in testMultiSolutionsJobs
    untangle=True)
  File
"/mnt/data/b/commit-queue/workdir/depot_tools/tests/gclient_smoketest.py", line
76, in parseGclient
    return self.checkBlock(stdout, items)
  File
"/mnt/data/b/commit-queue/workdir/depot_tools/tests/gclient_smoketest.py", line
129, in checkBlock
    self.checkString(results[i][0][2], path, (i, results[i][0][2], path))
  File "/mnt/data/b/commit-queue/workdir/depot_tools/tests/fake_repos.py", line
714, in checkString
    self.assertEquals(expected, result, msg)
AssertionError: (3,
'/tmp/trialmnifvD/__main__.GClientSmokeBoth.testMultiSolutionsJobs',
'/tmp/trialmnifvD/__main__.GClientSmokeBoth.testMultiSolutionsJobs/src/file/other')

----------------------------------------------------------------------
Ran 38 tests in 154.462s

FAILED (failures=1)
***************

Presubmit checks took 199.9s to calculate.

Presubmit check for 6725042-5001 failed with code 1

Powered by Google App Engine
This is Rietveld 408576698