[Arguments] Introduce a new backing store for non-strict arguments objects.

src/ia32/code-stubs-ia32.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 3592 matching lines @@
   __ push(edx);
   __ push(ebx);
   __ TailCallRuntime(Runtime::kGetArgumentsProperty, 1, 1);
 }
 
 
 void ArgumentsAccessStub::GenerateNewObject(MacroAssembler* masm) {
   // esp[0] : return address
   // esp[4] : number of parameters
   // esp[8] : receiver displacement
-  // esp[16] : function
+  // esp[12] : function
 
   // The displacement is used for skipping the return address and the
   // frame pointer on the stack. It is the offset of the last
   // parameter (if any) relative to the frame pointer.
   static const int kDisplacement = 2 * kPointerSize;
 
   // Check if the calling frame is an arguments adaptor frame.
   Label adaptor_frame, try_allocate, runtime;
   __ mov(edx, Operand(ebp, StandardFrameConstants::kCallerFPOffset));
   __ mov(ecx, Operand(edx, StandardFrameConstants::kContextOffset));
   __ cmp(Operand(ecx), Immediate(Smi::FromInt(StackFrame::ARGUMENTS_ADAPTOR)));
   __ j(equal, &adaptor_frame);
 
   // Get the length from the frame.
   __ mov(ecx, Operand(esp, 1 * kPointerSize));
   __ jmp(&try_allocate);
 
   // Patch the arguments.length and the parameters pointer.
   __ bind(&adaptor_frame);
   __ mov(ecx, Operand(edx, ArgumentsAdaptorFrameConstants::kLengthOffset));
   __ mov(Operand(esp, 1 * kPointerSize), ecx);
   __ lea(edx, Operand(edx, ecx, times_2, kDisplacement));
   __ mov(Operand(esp, 2 * kPointerSize), edx);
 
   // Try the new space allocation. Start out with computing the size of
   // the arguments object and the elements array.
   NearLabel add_arguments_object;
   __ bind(&try_allocate);
-  __ test(ecx, Operand(ecx));
-  __ j(zero, &add_arguments_object);
-  __ lea(ecx, Operand(ecx, times_2, FixedArray::kHeaderSize));
-  __ bind(&add_arguments_object);
-  __ add(Operand(ecx), Immediate(GetArgumentsObjectSize()));
+  if (type_ == NEW_NON_STRICT) {
+    __ TailCallRuntime(Runtime::kNewArgumentsFast, 3, 1);
+  } else {
+    __ test(ecx, Operand(ecx));
+    __ j(zero, &add_arguments_object);
+    __ lea(ecx, Operand(ecx, times_2, FixedArray::kHeaderSize));
+    __ bind(&add_arguments_object);
+    __ add(Operand(ecx), Immediate(GetArgumentsObjectSize()));
 
-  // Do the allocation of both objects in one go.
-  __ AllocateInNewSpace(ecx, eax, edx, ebx, &runtime, TAG_OBJECT);
+    // Do the allocation of both objects in one go.
+    __ AllocateInNewSpace(ecx, eax, edx, ebx, &runtime, TAG_OBJECT);
 
-  // Get the arguments boilerplate from the current (global) context.
-  __ mov(edi, Operand(esi, Context::SlotOffset(Context::GLOBAL_INDEX)));
-  __ mov(edi, FieldOperand(edi, GlobalObject::kGlobalContextOffset));
-  __ mov(edi, Operand(edi,
-                      Context::SlotOffset(GetArgumentsBoilerplateIndex())));
+    // Get the arguments boilerplate from the current (global) context.
+    __ mov(edi, Operand(esi, Context::SlotOffset(Context::GLOBAL_INDEX)));
+    __ mov(edi, FieldOperand(edi, GlobalObject::kGlobalContextOffset));
+    __ mov(edi, Operand(edi,
+                        Context::SlotOffset(GetArgumentsBoilerplateIndex())));
 
-  // Copy the JS object part.
-  for (int i = 0; i < JSObject::kHeaderSize; i += kPointerSize) {
-    __ mov(ebx, FieldOperand(edi, i));
-    __ mov(FieldOperand(eax, i), ebx);
+    // Copy the JS object part.
+    for (int i = 0; i < JSObject::kHeaderSize; i += kPointerSize) {
+      __ mov(ebx, FieldOperand(edi, i));
+      __ mov(FieldOperand(eax, i), ebx);
+    }
+
+    if (type_ == NEW_NON_STRICT) {
+      // Setup the callee in-object property.
+      STATIC_ASSERT(Heap::kArgumentsCalleeIndex == 1);
+      __ mov(ebx, Operand(esp, 3 * kPointerSize));
+      __ mov(FieldOperand(eax, JSObject::kHeaderSize +
+                          Heap::kArgumentsCalleeIndex * kPointerSize),
+             ebx);
+    }
+
+    // Get the length (smi tagged) and set that as an in-object property too.
+    STATIC_ASSERT(Heap::kArgumentsLengthIndex == 0);
+    __ mov(ecx, Operand(esp, 1 * kPointerSize));
+    __ mov(FieldOperand(eax, JSObject::kHeaderSize +
+                        Heap::kArgumentsLengthIndex * kPointerSize),
+           ecx);
+
+    // If there are no actual arguments, we're done.
+    Label done;
+    __ test(ecx, Operand(ecx));
+    __ j(zero, &done);
+
+    // Get the parameters pointer from the stack.
+    __ mov(edx, Operand(esp, 2 * kPointerSize));
+
+    // Setup the elements pointer in the allocated arguments object and
+    // initialize the header in the elements fixed array.
+    __ lea(edi, Operand(eax, GetArgumentsObjectSize()));
+    __ mov(FieldOperand(eax, JSObject::kElementsOffset), edi);
+    __ mov(FieldOperand(edi, FixedArray::kMapOffset),
+           Immediate(FACTORY->fixed_array_map()));
+
+    __ mov(FieldOperand(edi, FixedArray::kLengthOffset), ecx);
+    // Untag the length for the loop below.
+    __ SmiUntag(ecx);
+
+    // Copy the fixed array slots.
+    NearLabel loop;
+    __ bind(&loop);
+    __ mov(ebx, Operand(edx, -1 * kPointerSize));  // Skip receiver.
+    __ mov(FieldOperand(edi, FixedArray::kHeaderSize), ebx);
+    __ add(Operand(edi), Immediate(kPointerSize));
+    __ sub(Operand(edx), Immediate(kPointerSize));
+    __ dec(ecx);
+    __ j(not_zero, &loop);
+
+    // Return and remove the on-stack parameters.
+    __ bind(&done);
+    __ ret(3 * kPointerSize);
+
+    // Do the runtime call to allocate the arguments object.
+    __ bind(&runtime);
+    __ TailCallRuntime(Runtime::kNewStrictArgumentsFast, 3, 1);
   }
-
-  if (type_ == NEW_NON_STRICT) {
-    // Setup the callee in-object property.
-    STATIC_ASSERT(Heap::kArgumentsCalleeIndex == 1);
-    __ mov(ebx, Operand(esp, 3 * kPointerSize));
-    __ mov(FieldOperand(eax, JSObject::kHeaderSize +
-                             Heap::kArgumentsCalleeIndex * kPointerSize),
-           ebx);
-  }
-
-  // Get the length (smi tagged) and set that as an in-object property too.
-  STATIC_ASSERT(Heap::kArgumentsLengthIndex == 0);
-  __ mov(ecx, Operand(esp, 1 * kPointerSize));
-  __ mov(FieldOperand(eax, JSObject::kHeaderSize +
-                           Heap::kArgumentsLengthIndex * kPointerSize),
-         ecx);
-
-  // If there are no actual arguments, we're done.
-  Label done;
-  __ test(ecx, Operand(ecx));
-  __ j(zero, &done);
-
-  // Get the parameters pointer from the stack.
-  __ mov(edx, Operand(esp, 2 * kPointerSize));
-
-  // Setup the elements pointer in the allocated arguments object and
-  // initialize the header in the elements fixed array.
-  __ lea(edi, Operand(eax, GetArgumentsObjectSize()));
-  __ mov(FieldOperand(eax, JSObject::kElementsOffset), edi);
-  __ mov(FieldOperand(edi, FixedArray::kMapOffset),
-         Immediate(FACTORY->fixed_array_map()));
-
-  __ mov(FieldOperand(edi, FixedArray::kLengthOffset), ecx);
-  // Untag the length for the loop below.
-  __ SmiUntag(ecx);
-
-  // Copy the fixed array slots.
-  NearLabel loop;
-  __ bind(&loop);
-  __ mov(ebx, Operand(edx, -1 * kPointerSize));  // Skip receiver.
-  __ mov(FieldOperand(edi, FixedArray::kHeaderSize), ebx);
-  __ add(Operand(edi), Immediate(kPointerSize));
-  __ sub(Operand(edx), Immediate(kPointerSize));
-  __ dec(ecx);
-  __ j(not_zero, &loop);
-
-  // Return and remove the on-stack parameters.
-  __ bind(&done);
-  __ ret(3 * kPointerSize);
-
-  // Do the runtime call to allocate the arguments object.
-  __ bind(&runtime);
-  __ TailCallRuntime(Runtime::kNewArgumentsFast, 3, 1);
 }
 
 
 void RegExpExecStub::Generate(MacroAssembler* masm) {
   // Just jump directly to runtime if native RegExp is not selected at compile
   // time or if regexp entry in generated code is turned off runtime switch or
   // at compilation.
 #ifdef V8_INTERPRETED_REGEXP
   __ TailCallRuntime(Runtime::kRegExpExec, 4, 1);
 #else  // V8_INTERPRETED_REGEXP
@@ skipping 2754 matching lines @@
   // Do a tail call to the rewritten stub.
   __ jmp(Operand(edi));
 }
 
 
 #undef __
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_IA32