Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 6725015: verity: remove short-circuiting of verify_path (Closed)

Created:
9 years, 9 months ago by Mandeep Singh Baines
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

verity: remove short-circuiting of verify_path This removes the optimization which short-circuited verify_path. The net result is the addition of a few cycles and the removal of a few so zero or negligible cycles added. The main benefit is the removal of the one of the larget comments in the code. Ran BootPerfServer to verify no noticable overhead added. Before: seconds_power_on_to_login 8.44 After: seconds_power_on_to_login 8.4 This result is within variance. BUG=9752 TEST=Ran dm-verity.git unit tests. Ran platform_DMVerityCorruption on H/W. Signed-off-by: Mandeep Singh Baines <msb@chromium.org>; kernel.git Review URL: http://codereview.chromium.org/6659004 TBRing because this has already been LGTMed and committed to kernel.git. Change-Id: Ib9384f3a5addc014f679cc1d46638bf782b12c9f TBR=wad@chromium.org,taysom@chromium.org,ups@chromium.org Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=5619bb3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -14 lines) Patch
M dm-bht.c View 4 chunks +3 lines, -14 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Mandeep Singh Baines
9 years, 9 months ago (2011-03-22 23:25:42 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698