Issue 6725014: Cleanup of FACTORY macro usage in api.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6725014: Cleanup of FACTORY macro usage in api.cc. (Closed)

Created:
9 years, 9 months ago by Peter Varga

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
git://github.com/v8/v8.git@master

Visibility:
Public.

Description

Cleanup of FACTORY macro usage in api.cc. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=7314

Patch Set 1 #

Total comments: 1

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -28 lines)			Patch
	M	AUTHORS	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/api.cc	View		25 chunks	+29 lines, -28 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Peter Varga

The FACTORY macro (v8::internal::Isolate::Current()->factory()) is unnecessarily used in few cases in api.cc. This macro should ...

9 years, 9 months ago (2011-03-22 22:54:16 UTC) #1

Mads Ager (chromium)

9 years, 9 months ago (2011-03-23 08:50:37 UTC) #2

LGTM. I will fix the presubmit errors and commit.

http://codereview.chromium.org/6725014/diff/1/src/api.cc
File src/api.cc (right):

http://codereview.chromium.org/6725014/diff/1/src/api.cc#newcode2619
src/api.cc:2619: i::Handle<i::JSArray> result =
isolate->factory()->NewJSArrayWithElements(elms);
Line too long. Please run ./tools/presubmit.py before uploading. :-)

Expand Messages | Collapse Messages