Base: First pass at having base.dll: definition of

base/synchronization/lock_impl.h

Index: base/synchronization/lock_impl.h
===================================================================
--- base/synchronization/lock_impl.h	(revision 78949)
+++ base/synchronization/lock_impl.h	(working copy)
@@ -14,6 +14,7 @@
 #include <pthread.h>
 #endif
 
+#include "base/base_api.h"
 #include "base/basictypes.h"
 
 namespace base {
@@ -22,7 +23,7 @@
 // This class implements the underlying platform-specific spin-lock mechanism
 // used for the Lock class.  Most users should not use LockImpl directly, but
 // should instead use Lock.
-class LockImpl {
+class BASE_API LockImpl {

[wtc, 2011/03/23 22:05:12]

Why does an internal class LockImpl need BASE_API?
The exported class Lock only contains a pointer to LockImpl.

[rvargas (doing something else), 2011/03/23 22:59:04]

I swear I tried without modifying this file and the linker complained (for
net_unittests). But I just tried again and it worked fine :(. It could have been
because most of this patch is quite old; I originally did this with the code
from early January, and maybe there was an extra dependency.

Anyways, I'll remove this on another CL.

  public:
 #if defined(OS_WIN)
   typedef CRITICAL_SECTION OSLockType;