Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1463)

Unified Diff: chrome/browser/safe_browsing/protocol_manager.cc

Issue 67243: Reduce the false positive rate for SafeBrowsing gethash requests (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/safe_browsing_database_bloom.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/protocol_manager.cc
===================================================================
--- chrome/browser/safe_browsing/protocol_manager.cc (revision 13914)
+++ chrome/browser/safe_browsing/protocol_manager.cc (working copy)
@@ -196,6 +196,12 @@
std::vector<SBFullHashResult> full_hashes;
bool can_cache = false;
if (response_code == 200 || response_code == 204) {
+ // For tracking our GetHash false positive (204) rate, compared to real
+ // (200) responses.
+ if (response_code == 200)
+ UMA_HISTOGRAM_COUNTS("SB2.GetHash200", 1);
+ else
+ UMA_HISTOGRAM_COUNTS("SB2.GetHash204", 1);
can_cache = true;
gethash_error_count_ = 0;
gethash_back_off_mult_ = 1;
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/safe_browsing_database_bloom.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698