Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Unified Diff: remoting/protocol/host_stub.h

Issue 6724033: Remove authenticated_ fields from stubs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address reviewer's comments. Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/host_message_dispatcher.cc ('k') | remoting/protocol/host_stub.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/host_stub.h
diff --git a/remoting/protocol/host_stub.h b/remoting/protocol/host_stub.h
index 737154db5580f2beffb6002bab32f3094d4da046..2a18ffe9ee36c4bb8a5b2aa321385c7be4c185a4 100644
--- a/remoting/protocol/host_stub.h
+++ b/remoting/protocol/host_stub.h
@@ -4,7 +4,7 @@
// Interface of a host that receives commands from a Chromoting client.
//
-// This interface handles control messages defined in contro.proto.
+// This interface handles control messages defined in control.proto.
#ifndef REMOTING_PROTOCOL_HOST_STUB_H_
#define REMOTING_PROTOCOL_HOST_STUB_H_
@@ -21,35 +21,15 @@ class SuggestResolutionRequest;
class HostStub {
public:
- HostStub();
- virtual ~HostStub();
+ HostStub() {};
+ virtual ~HostStub() {};
virtual void SuggestResolution(
const SuggestResolutionRequest* msg, Task* done) = 0;
virtual void BeginSessionRequest(
const LocalLoginCredentials* credentials, Task* done) = 0;
- // TODO(lambroslambrou): Remove OnAuthenticated() and OnClosed() when stubs
- // are refactored not to store authentication state.
-
- // Called when the client has authenticated with the host to enable the
- // client->host control channel.
- // Before this is called, only a limited set of control messages will be
- // processed.
- void OnAuthenticated();
-
- // Called when the client is no longer connected.
- void OnClosed();
-
- // Has the client successfully authenticated with the host?
- // I.e., should we be processing control events?
- bool authenticated();
-
private:
- // Initially false, this records whether the client has authenticated with
- // the host.
- bool authenticated_;
-
DISALLOW_COPY_AND_ASSIGN(HostStub);
};
« no previous file with comments | « remoting/protocol/host_message_dispatcher.cc ('k') | remoting/protocol/host_stub.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698