Remove authenticated_ fields from stubs.

remoting/host/client_session.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_HOST_CLIENT_SESSION_H_
 #define REMOTING_HOST_CLIENT_SESSION_H_
 
 #include "remoting/protocol/connection_to_client.h"
 #include "remoting/protocol/host_stub.h"
+#include "remoting/protocol/input_stub.h"
 
 namespace remoting {
 
+class UserAuthenticator;
+
 // A ClientSession keeps a reference to a connection to a client, and maintains
 // per-client state.
 class ClientSession : public protocol::HostStub,
+                      public protocol::InputStub,
                       public base::RefCountedThreadSafe<ClientSession> {
  public:
   // Callback interface for passing events to the ChromotingHost.
   class EventHandler {
    public:
     virtual ~EventHandler() {}
 
     // Called to signal that local login has succeeded and ChromotingHost can
     // proceed with the next step.
     virtual void LocalLoginSucceeded(
         scoped_refptr<protocol::ConnectionToClient> client) = 0;
 
     // Called to signal that local login has failed.
     virtual void LocalLoginFailed(
         scoped_refptr<protocol::ConnectionToClient> client) = 0;
   };
 
   ClientSession(EventHandler* event_handler,
-                scoped_refptr<protocol::ConnectionToClient> connection);
+                const base::Callback<UserAuthenticator*(void)>& auth_factory,

[Alpha Left Google, 2011/03/28 16:22:26]

I'm a but confused looking at this, can you do some typedef?
Usually for complex type like this we use typedefs so as to make code more
readable.

[simonmorris, 2011/03/29 17:07:51]

Done.

+                scoped_refptr<protocol::ConnectionToClient> connection,
+                protocol::InputStub* input_stub);
 
   // protocol::HostStub interface.
   virtual void SuggestResolution(
       const protocol::SuggestResolutionRequest* msg, Task* done);
   virtual void BeginSessionRequest(
       const protocol::LocalLoginCredentials* credentials, Task* done);
 
+  // protocol::InputStub interface.
+  virtual void InjectKeyEvent(const protocol::KeyEvent* event, Task* done);
+  virtual void InjectMouseEvent(const protocol::MouseEvent* event, Task* done);
+
   // Disconnect this client session.
   void Disconnect();
 
   protocol::ConnectionToClient* connection() const;

[Alpha Left Google, 2011/03/28 16:22:26]

nit: this getter can be inline.

[simonmorris, 2011/03/29 17:07:51]

Done.

+  bool authenticated() const;

[Alpha Left Google, 2011/03/28 16:22:26]

nit: for simple getter like this you can simply do inline.

[simonmorris, 2011/03/29 17:07:51]

Done.

 
  protected:

[Alpha Left Google, 2011/03/28 16:22:26]

nit: Is there other class that inherit this? I think we can remove this
protected section. In general the coding style is we should have only public and
private, and no sharing members between subclasses. In this case it seems
unnecessary to have protected.

[simonmorris, 2011/03/29 17:07:51]

Done.

   friend class base::RefCountedThreadSafe<ClientSession>;
   ~ClientSession();

[Alpha Left Google, 2011/03/28 16:22:26]

virtual ~ClientSession();

[simonmorris, 2011/03/29 17:07:51]

Done.

 
  private:
   EventHandler* event_handler_;
+
+  // A factory for user authenticators.
+  base::Callback<UserAuthenticator*(void)> auth_factory_;
+
+  // The connection to the client.
   scoped_refptr<protocol::ConnectionToClient> connection_;
 
+  // The input stub to which this object delegates.
+  protocol::InputStub* input_stub_;
+
+  // Whether this client is authenticated.
+  bool authenticated_;
+
   DISALLOW_COPY_AND_ASSIGN(ClientSession);
 };
 
 }  // namespace remoting
 
 #endif  // REMOTING_HOST_CLIENT_SESSION_H_