Remove authenticated_ fields from stubs.

remoting/protocol/host_message_dispatcher.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/ref_counted.h"
 #include "net/base/io_buffer.h"
 #include "remoting/proto/control.pb.h"
 #include "remoting/proto/event.pb.h"
 #include "remoting/proto/internal.pb.h"
 #include "remoting/protocol/connection_to_client.h"
@@ skipping 31 matching lines @@
   event_message_reader_->Init(
       session->event_channel(),
       NewCallback(this, &HostMessageDispatcher::OnEventMessageReceived));
   control_message_reader_->Init(
       session->control_channel(),
       NewCallback(this, &HostMessageDispatcher::OnControlMessageReceived));
 }
 
 void HostMessageDispatcher::OnControlMessageReceived(
     ControlMessage* message, Task* done_task) {
-  // BeginSessionRequest is always allowed.
+  // TODO(sergeyu): Add message validation.
   if (message->has_begin_session_request()) {
     host_stub_->BeginSessionRequest(
         &message->begin_session_request().credentials(), done_task);
     return;
   }
-  if (!host_stub_->authenticated()) {
-    // When the client has not authenticated with the host, no other messages
-    // are allowed.
-    LOG(WARNING) << "Invalid control message received "
-                 << "(client not authenticated).";
-  } else {
-    // TODO(sergeyu): Add message validation.
-    if (message->has_suggest_resolution()) {
-      host_stub_->SuggestResolution(&message->suggest_resolution(), done_task);
-      return;
-    } else {
-      LOG(WARNING) << "Invalid control message received.";
-    }
+  if (message->has_suggest_resolution()) {
+    host_stub_->SuggestResolution(&message->suggest_resolution(), done_task);
+    return;
   }
+  LOG(WARNING) << "Invalid control message received.";

[Wez, 2011/03/30 20:24:57]

If not authenticated, disconnect?

[simonmorris, 2011/03/31 11:14:00]

Could be good, in another CL.

   done_task->Run();
   delete done_task;
 }
 
 void HostMessageDispatcher::OnEventMessageReceived(
     EventMessage* message, Task* done_task) {
-  if (input_stub_->authenticated()) {
-    // TODO(sergeyu): Add message validation.
-    if (message->has_key_event()) {
-      input_stub_->InjectKeyEvent(&message->key_event(), done_task);
-    } else if (message->has_mouse_event()) {
-      input_stub_->InjectMouseEvent(&message->mouse_event(), done_task);
-    } else {
-      LOG(WARNING) << "Invalid event message received.";
-      done_task->Run();
-      delete done_task;
-    }
+  // TODO(sergeyu): Add message validation.
+  if (message->has_key_event()) {
+    input_stub_->InjectKeyEvent(&message->key_event(), done_task);
+  } else if (message->has_mouse_event()) {
+    input_stub_->InjectMouseEvent(&message->mouse_event(), done_task);
+  } else {
+    LOG(WARNING) << "Invalid event message received.";
+    done_task->Run();
+    delete done_task;

[Wez, 2011/03/30 20:24:57]

If not authenticated, disconnect?

nit: This block is equivalent to the one in OnControlMessageReceived; could they
be laid out in the same style as one another?

[simonmorris, 2011/03/31 11:14:00]

Done.

   }
 }
 
 }  // namespace protocol
 }  // namespace remoting