Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1027)

Issue 6724026: Clean up unload-related state after the ack is received. (Closed)

Created:
9 years, 9 months ago by Charlie Reis
Modified:
9 years, 7 months ago
CC:
chromium-reviews, jam
Visibility:
Public.

Description

Clean up unload-related state after the ack is received. BUG=76666 TEST=RenderViewHostManagerTest.ClickLinkAfter204Error Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79440

Patch Set 1 : Clean up ClosePage state. #

Patch Set 2 : Add browser test. #

Total comments: 7

Patch Set 3 : Address comments. #

Patch Set 4 : Merge with test flakiness fix CL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -6 lines) Patch
M content/browser/renderer_host/render_view_host.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host.cc View 1 2 3 2 chunks +15 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_manager_browsertest.cc View 1 2 3 1 chunk +58 lines, -0 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host.cc View 1 2 3 1 chunk +6 lines, -4 lines 0 comments Download
M net/tools/testserver/testserver.py View 1 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Charlie Reis
I'd like to include a browser test for this, showing that a renderer can still ...
9 years, 9 months ago (2011-03-23 20:41:05 UTC) #1
Paweł Hajdan Jr.
On 2011/03/23 20:41:05, creis wrote: > I'd like to include a browser test for this, ...
9 years, 9 months ago (2011-03-23 20:43:37 UTC) #2
Charlie Reis
Thanks for the tip! Paweł, could you review my changes to testserver.py and take a ...
9 years, 9 months ago (2011-03-23 23:48:27 UTC) #3
Paweł Hajdan Jr.
Test changes LGTM with comments. http://codereview.chromium.org/6724026/diff/5001/content/browser/renderer_host/render_view_host_manager_browsertest.cc File content/browser/renderer_host/render_view_host_manager_browsertest.cc (right): http://codereview.chromium.org/6724026/diff/5001/content/browser/renderer_host/render_view_host_manager_browsertest.cc#newcode238 content/browser/renderer_host/render_view_host_manager_browsertest.cc:238: default: Do you want ...
9 years, 9 months ago (2011-03-24 16:37:22 UTC) #4
brettw
LGTM http://codereview.chromium.org/6724026/diff/5001/content/browser/renderer_host/render_view_host.cc File content/browser/renderer_host/render_view_host.cc (right): http://codereview.chromium.org/6724026/diff/5001/content/browser/renderer_host/render_view_host.cc#newcode327 content/browser/renderer_host/render_view_host.cc:327: if (!for_cross_site_transition) { Can you add a comment ...
9 years, 9 months ago (2011-03-24 20:27:49 UTC) #5
Charlie Reis
9 years, 9 months ago (2011-03-24 22:46:03 UTC) #6
Thanks guys.  I'll run a final set of try jobs here after I land the flaky test
fix in http://codereview.chromium.org/6730016/.

http://codereview.chromium.org/6724026/diff/5001/content/browser/renderer_hos...
File content/browser/renderer_host/render_view_host.cc (right):

http://codereview.chromium.org/6724026/diff/5001/content/browser/renderer_hos...
content/browser/renderer_host/render_view_host.cc:327: if
(!for_cross_site_transition) {
On 2011/03/24 20:27:49, brettw wrote:
> Can you add a comment here about why this condition exists?

Done.

http://codereview.chromium.org/6724026/diff/5001/content/browser/renderer_hos...
File content/browser/renderer_host/render_view_host_manager_browsertest.cc
(right):

http://codereview.chromium.org/6724026/diff/5001/content/browser/renderer_hos...
content/browser/renderer_host/render_view_host_manager_browsertest.cc:238:
default:
On 2011/03/24 16:37:22, Paweł Hajdan Jr. wrote:
> Do you want NOTREACHED in the default case?

Sure.  I've also fixed it as part of http://codereview.chromium.org/6730016/,
which I plan to land first.

http://codereview.chromium.org/6724026/diff/5001/content/browser/renderer_hos...
content/browser/renderer_host/render_view_host_manager_browsertest.cc:286:
net::TestServer https_server_(
On 2011/03/24 16:37:22, Paweł Hajdan Jr. wrote:
> nit: Remove underscore from the end of variable name ( _ ).

Done.

http://codereview.chromium.org/6724026/diff/5001/content/browser/renderer_hos...
content/browser/renderer_host/render_view_host_manager_browsertest.cc:331:
browser()->GetSelectedTabContents()->GetTitle());
I've now fixed the flakiness around this, too (as uncovered in the other CL).

Powered by Google App Engine
This is Rietveld 408576698