Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 6724018: use crossystem for developer mode and nonchrome detection (Closed)

Created:
9 years, 9 months ago by Will Drewry
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

use crossystem for developer mode and nonchrome detection Adds crossystem use for developer mode detection and nonchrome detection. [This allows systems with missing or damaged TPMs or bad firmware to go through recovery as nonchrome systems.] (testing in progress) TEST=create a devkeys x86-alex image, boot it and install it in both modes same thing for x86-mario boot x86-mario, goto a shell, run crossystem mainfw_act to ensure it never says nonchrome again for a nonchrome system BUG=chromium-os:13399, chromium-os:8762 Change-Id: I538fe37fbed29537132da15c844b75ce726634bf R=gauravsh@chromium.org Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=28966b0

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -13 lines) Patch
M init View 3 chunks +26 lines, -13 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
Will Drewry
9 years, 9 months ago (2011-03-23 01:42:09 UTC) #1
gauravsh
LGTM with a comment http://codereview.chromium.org/6724018/diff/1/init File init (right): http://codereview.chromium.org/6724018/diff/1/init#newcode576 init:576: crossystem mainfw_type?nonchrome it wasn't clear ...
9 years, 9 months ago (2011-03-23 02:25:18 UTC) #2
Randall Spangler
9 years, 9 months ago (2011-03-23 15:54:17 UTC) #3
http://codereview.chromium.org/6724018/diff/1/init
File init (right):

http://codereview.chromium.org/6724018/diff/1/init#newcode576
init:576: crossystem mainfw_type?nonchrome
On 2011/03/23 02:25:18, gauravsh wrote:
> it wasn't clear to me what exactly this does. Does crosystem return 0 (i.e .
> succed) if mainfwtype=='nonchrome'?

Yes.  (New feature of crossystem)

Powered by Google App Engine
This is Rietveld 408576698