Take the ANGLE path for glRenderbufferStorageMultisample when on ANGLE.

Take the ANGLE path for glRenderbufferStorageMultisample when on ANGLE.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79121

[bsalomon, 2011-03-22 21:16:06]

Hi, This fixes a crash in the command buffer decode when handling
glRenderbufferStorageMultisample on ANGLE. Please take a look.

[Ken Russell (switch to Gerrit), 2011-03-22 21:18:45]

LGTM

[apatrick_chromium, 2011-03-22 21:19:41]

LGTM

[twiz, 2011-03-22 21:58:17]

LGTM.

http://codereview.chromium.org/6724004/diff/1/gpu/command_buffer/service/gles...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

http://codereview.chromium.org/6724004/diff/1/gpu/command_buffer/service/gles...
gpu/command_buffer/service/gles2_cmd_decoder.cc:3631: }
Are there other instances where similiar changes will be required?

[reed1, 2011-03-23 12:15:18]

Is that the right formatting for { } and if/else in the surrounding code? I like
it, but this file may be styled differently.

[bsalomon, 2011-03-23 13:44:31]

chromium.org says Chromium follows the Google style guide. The braces in this
file look consistent with this:

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Condit...

Those guidelines leave a fair amount of discretion, though.

BTW this passed mac, linux, linux_chromeos, and win_layout try bots. I submitted
them before the gcl upload without realizing that they wouldn't show up here.
I'm going to commit it.


On 2011/03/23 12:15:18, reed1 wrote:
> Is that the right formatting for { } and if/else in the surrounding code? I
like
> it, but this file may be styled differently.