Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 67234: Buildbot changes for running page_cycler_http on Mac (Closed)

Created:
11 years, 8 months ago by Nirnimesh
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai, TVL
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add support for running httpd on Mac for test. Buildbot changes for running page_cycler_http on Mac Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13951

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -4 lines) Patch
M config/master.chromium/master.cfg View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M scripts/slave/runtest.py View 1 2 2 chunks +32 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Nirnimesh
11 years, 8 months ago (2009-04-16 22:32:21 UTC) #1
Mark Mentovai
Looks good (obviously after the other one lands). http://codereview.chromium.org/67234/diff/6/1002 File scripts/slave/runtest.py (right): http://codereview.chromium.org/67234/diff/6/1002#newcode53 Line 53: ...
11 years, 8 months ago (2009-04-16 23:00:33 UTC) #2
TVL
lgtm too
11 years, 8 months ago (2009-04-17 13:08:32 UTC) #3
Nirnimesh
11 years, 8 months ago (2009-04-17 13:33:13 UTC) #4
http://codereview.chromium.org/67234/diff/6/1002
File scripts/slave/runtest.py (right):

http://codereview.chromium.org/67234/diff/6/1002#newcode53
Line 53: test_exe_name = os.path.basename(test_exe_path).rsplit('.', 1)[0]
On 2009/04/16 23:00:34, Mark Mentovai wrote:
> test_exe_name = os.path.splitext(os.path.basename(test_exe_path))[0]

Done.

Powered by Google App Engine
This is Rietveld 408576698