Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Unified Diff: src/objects.cc

Issue 6723001: Some Isolate usage cleanups in objects.{h,cc}. (Closed)
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.h ('k') | src/objects-inl.h » ('j') | src/objects-inl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index da751477338fefbb40ac95ab22a8e658fd21a687..a2b35ef45dd3a814351d7d5fa82c95bbec2ec7ac 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -1259,7 +1259,7 @@ MaybeObject* JSObject::AddFastProperty(String* name,
Isolate* isolate = GetHeap()->isolate();
StringInputBuffer buffer(name);
if (!isolate->scanner_constants()->IsIdentifier(&buffer)
- && name != HEAP->hidden_symbol()) {
+ && name != isolate->heap()->hidden_symbol()) {
Object* obj;
{ MaybeObject* maybe_obj =
NormalizeProperties(CLEAR_INOBJECT_PROPERTIES, 0);
@@ -5211,8 +5211,6 @@ static inline bool CompareStringContentsPartial(Isolate* isolate,
bool String::SlowEquals(String* other) {
- Heap* heap = GetHeap();
-
// Fast check: negative check with lengths.
int len = length();
if (len != other->length()) return false;
@@ -5239,7 +5237,7 @@ bool String::SlowEquals(String* other) {
Vector<const char>(str2, len));
}
- Isolate* isolate = heap->isolate();
+ Isolate* isolate = GetIsolate();
if (lhs->IsFlat()) {
if (lhs->IsAsciiRepresentation()) {
Vector<const char> vec1 = lhs->ToAsciiVector();
« no previous file with comments | « src/objects.h ('k') | src/objects-inl.h » ('j') | src/objects-inl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698