Issue 6723001: Some Isolate usage cleanups in objects.{h,cc}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6723001: Some Isolate usage cleanups in objects.{h,cc}. (Closed)

Created:
9 years, 9 months ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Some Isolate usage cleanups in objects.{h,cc}. Committed: http://code.google.com/p/v8/source/detail?r=7312

Patch Set 1 #

Total comments: 1

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -11 lines)			Patch
M	src/objects.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/objects.cc	View	3 chunks	+2 lines, -4 lines	0 comments	Download
M	src/objects-inl.h	View	5 chunks	+9 lines, -6 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

9 years, 9 months ago (2011-03-22 19:05:36 UTC) #2

LGTM!

http://codereview.chromium.org/6723001/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

http://codereview.chromium.org/6723001/diff/1/src/objects-inl.h#newcode2856
src/objects-inl.h:2856:
isolate()->counters()->map_slow_to_fast_elements()->Increment();
Hey, that's part of my next change! ;-)

Expand Messages | Collapse Messages