Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Unified Diff: gcl.py

Issue 6722014: For now, stop suggesting reviewers during 'gcl change'. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/gcl_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gcl.py
diff --git a/gcl.py b/gcl.py
index 20762d1be0c5bdbb277170c046608585f459397a..fe04b99af8514bf90f5130cdf15ddb4034f6c16e 100755
--- a/gcl.py
+++ b/gcl.py
@@ -763,12 +763,6 @@ def OptionallyDoPresubmitChecks(change_info, committing, args):
return DoPresubmitChecks(change_info, committing, True)
-def suggest_reviewers(change_info, affected_files):
- owners_db = owners.Database(change_info.GetLocalRoot(), fopen=file,
- os_path=os.path)
- return owners_db.reviewers_for([f[1] for f in affected_files])
-
-
def defer_attributes(a, b):
"""Copy attributes from an object (like a function) to another."""
for x in dir(a):
@@ -1098,15 +1092,6 @@ def CMDchange(args):
affected_files = [x for x in other_files if file_re.match(x[0])]
unaffected_files = [x for x in other_files if not file_re.match(x[0])]
- if not change_info.reviewers:
- files_for_review = affected_files[:]
- files_for_review.extend(change_info.GetFiles())
- suggested_reviewers = suggest_reviewers(change_info, files_for_review)
- if suggested_reviewers:
- reviewers_re = re.compile(REVIEWERS_REGEX)
- if not any(reviewers_re.match(l) for l in description.splitlines()):
- description += '\n\nR=' + ','.join(suggested_reviewers)
-
description = description.rstrip() + '\n'
separator1 = ("\n---All lines above this line become the description.\n"
« no previous file with comments | « no previous file | tests/gcl_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698