Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 6722011: Sync prtypes.h (NSPR in base) with upstream file revision 3.43 (Closed)

Created:
9 years, 9 months ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
wtc
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Sync prtypes.h (NSPR in base) with upstream file revision 3.43. http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/nsprpub/pr/include/prtypes.h&rev=HEAD&mark=3.43 This picks up a 64-bit Mac OS X fix from upstream bug 478687. https://bugzilla.mozilla.org/show_bug.cgi?id=478687 BUG=44127, 18323 TEST=64-bit base should all (mostly) build Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79251

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -75 lines) Patch
M base/third_party/nspr/prtypes.h View 15 chunks +43 lines, -75 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Mentovai
9 years, 9 months ago (2011-03-23 16:04:29 UTC) #1
wtc
LGTM. I forgot that the upstream prtypes.h has several spaces at the end of lines. ...
9 years, 9 months ago (2011-03-23 22:30:04 UTC) #2
Mark Mentovai
9 years, 9 months ago (2011-03-24 04:33:22 UTC) #3
We can pull in a new version of the file when it’s fixed upstream. Thanks for
the review.

Powered by Google App Engine
This is Rietveld 408576698