Issue 6721029: Fix locale.getlocale() exception.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6721029: Fix locale.getlocale() exception. (Closed)

Created:
9 years, 9 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Fix locale.getlocale() exception. Reapply r79006 with fixes for ubuntu 10.4. The only change is in fix_default_encoding() to trap an exception locale.getlocale() may throw. R=dpranke@chromium.org BUG=none TEST=unit test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79144

Created: 9 years, 9 months ago

	Unified diffs	Side-by-side diffs	Stats (+442 lines, -14 lines)
M	PRESUBMIT.py	View	1 chunk	+1 line, -0 lines	0 comments
A	fix_encoding.py	View	1 chunk	+356 lines, -0 lines	0 comments
M	gcl.py	View	2 chunks	+2 lines, -0 lines	0 comments
M	gclient.py	View	2 chunks	+2 lines, -0 lines	0 comments
M	presubmit_support.py	View	3 chunks	+13 lines, -11 lines	0 comments
A	tests/fix_encoding_test.py	View	1 chunk	+60 lines, -0 lines	0 comments
M	tests/gcl_unittest.py	View	1 chunk	+2 lines, -1 line	0 comments
M	tests/presubmit_unittest.py	View	1 chunk	+2 lines, -1 line	0 comments
M	tests/trychange_unittest.py	View	1 chunk	+2 lines, -1 line	0 comments
M	trychange.py	View	2 chunks	+2 lines, -0 lines	0 comments

Total messages: 2 (0 generated)

LGTM.