Issue 6721018: CHROMIUM: verity: use sg_set_buf instead of sg_set_page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6721018: CHROMIUM: verity: use sg_set_buf instead of sg_set_page (Closed)

Created:
9 years, 9 months ago by Mandeep Singh Baines

Modified:
9 years, 7 months ago

Reviewers:
Paul T, ups, Will Drewry

CC:
chromium-os-reviews_chromium.org

Base URL:
http://git.chromium.org/git/dm-verity.git@master

Visibility:
Public.

Description

CHROMIUM: verity: use sg_set_buf instead of sg_set_page This is in preparation for removing the assumption that the block size = PAGE_SIZE. BUG=9752 TEST=Ran tests in verity.git. Ran platform_DMVerityCorruption on H/W. Signed-off-by: Mandeep Singh Baines <msb@chromium.org>; kernel.git Review URL: http://codereview.chromium.org/6684008 TBRing. Already committed to kernel.git. Change-Id: Ia80b9466d7710ab32e5026ce46d5a2078338aeff R=wad@chromium.org,taysom@chromium.org,ups@chromium.org Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=9627dae

Patch Set 1 #

Total comments: 1

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -11 lines)			Patch
	M	dm-bht.c	View		8 chunks	+16 lines, -11 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Paul T

9 years, 9 months ago (2011-03-23 14:49:11 UTC) #2

LGTM

http://codereview.chromium.org/6721018/diff/1/dm-bht.c
File dm-bht.c (right):

http://codereview.chromium.org/6721018/diff/1/dm-bht.c#newcode109
dm-bht.c:109: 
nit: support instead of supporting

Expand Messages | Collapse Messages