Add WebKit API to retrieve the audio hardware sample-rate

Add WebKit API to retrieve the audio hardware sample-rate
BUG=none 
TEST=none 
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79088

[Ken Russell (switch to Gerrit), 2011-03-23 00:11:41]

LGTM

[scherkus (not reviewing), 2011-03-23 04:57:56]

drive by / post-commit nits+comments

you can TBR the style stuff but I'm interested in hearing about the default
sample rate stuff

http://codereview.chromium.org/6721015/diff/6001/content/renderer/renderer_we...
File content/renderer/renderer_webkitclient_impl.cc (right):

http://codereview.chromium.org/6721015/diff/6001/content/renderer/renderer_we...
content/renderer/renderer_webkitclient_impl.cc:540: return
media::GetAudioHardwareSampleRate();
nit: two space indent

http://codereview.chromium.org/6721015/diff/6001/media/audio/audio_util.cc
File media/audio/audio_util.cc (right):

http://codereview.chromium.org/6721015/diff/6001/media/audio/audio_util.cc#ne...
media/audio/audio_util.cc:226: {
nit: chromium style has brackets go on the function

http://codereview.chromium.org/6721015/diff/6001/media/audio/audio_util.cc#ne...
media/audio/audio_util.cc:228: // Hardware sample-rate on the Mac can be
configured, so we must query.
nit: two space indent

http://codereview.chromium.org/6721015/diff/6001/media/audio/audio_util.cc#ne...
media/audio/audio_util.cc:232: // TODO(crogers) : return correct value in rare
non-48KHz cases.
this isn't quite true... in fact chrome os was shipping with 44.1khz default (I
think) but we're changing it back to 48khz

do you have any intention on implementing this?  can we get a bug filed?

[Chris Rogers, 2011-03-24 00:19:38]

Hi Andrew, I'll work on a patching up your style nits.

The function is supposed to return the actual sample-rate of the hardware
itself.  Are you talking about something the hardware vendors are changing? 
I've created this bug to track this:
http://code.google.com/p/chromium/issues/detail?id=77239&can=4&colspec=ID%20S...

On 2011/03/23 04:57:56, scherkus wrote:
> 
>
http://codereview.chromium.org/6721015/diff/6001/media/audio/audio_util.cc#ne...
> media/audio/audio_util.cc:232: // TODO(crogers) : return correct value in rare
> non-48KHz cases.
> this isn't quite true... in fact chrome os was shipping with 44.1khz default
(I
> think) but we're changing it back to 48khz
> 
> do you have any intention on implementing this?  can we get a bug filed?

[Chris Rogers, 2011-03-24 00:21:10]

Sorry, that URL seems broken - the issue number is 77239

[scherkus (not reviewing), 2011-03-24 22:14:00]

On 2011/03/24 00:21:10, Chris Rogers wrote:
> Sorry, that URL seems broken - the issue number is 77239

Got it -- much appreciated!