Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2518)

Unified Diff: chrome/browser/extensions/extension_context_menu_model.cc

Issue 6721013: extensions: Refactor ExtensionInstallUI class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sort gypi Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_context_menu_model.cc
diff --git a/chrome/browser/extensions/extension_context_menu_model.cc b/chrome/browser/extensions/extension_context_menu_model.cc
index 3dd09b20f52b1c1456104ebd887b75fe88a6a133..47bbfe4140f38b1fd825d9542a355d9ab072939a 100644
--- a/chrome/browser/extensions/extension_context_menu_model.cc
+++ b/chrome/browser/extensions/extension_context_menu_model.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -127,9 +127,9 @@ void ExtensionContextMenuModel::ExecuteCommand(int command_id) {
break;
}
case UNINSTALL: {
- AddRef(); // Balanced in InstallUIProceed and InstallUIAbort.
- install_ui_.reset(new ExtensionInstallUI(profile_));
- install_ui_->ConfirmUninstall(this, extension);
+ AddRef(); // Balanced in Accepted() and Canceled()
+ extension_generic_dialog_.reset(new ExtensionGenericDialog(profile_));
+ extension_generic_dialog_->ConfirmUninstall(this, extension);
break;
}
case MANAGE: {
@@ -147,14 +147,14 @@ void ExtensionContextMenuModel::ExecuteCommand(int command_id) {
}
}
-void ExtensionContextMenuModel::InstallUIProceed() {
+void ExtensionContextMenuModel::ExtensionDialogAccepted() {
if (GetExtension())
profile_->GetExtensionService()->UninstallExtension(extension_id_, false);
Release();
}
-void ExtensionContextMenuModel::InstallUIAbort() {
+void ExtensionContextMenuModel::ExtensionDialogCanceled() {
Release();
}

Powered by Google App Engine
This is Rietveld 408576698